Skip to content

Commit fcfb48e

Browse files
committed
Refactoring in the OMPT backend.
MasterCallbacks -> MaskedCallbacks onMaster -> onMasked Version-dependent callback registration.
1 parent 1d08f9c commit fcfb48e

2 files changed

Lines changed: 18 additions & 9 deletions

File tree

include/opdi/backend/ompt/masterCallbacks.hpp renamed to include/opdi/backend/ompt/maskedCallbacks.hpp

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@
3434

3535
namespace opdi {
3636

37-
struct MasterCallbacks : public virtual CallbacksBase {
37+
struct MaskedCallbacks : public virtual CallbacksBase {
3838

3939
private:
4040

41-
static void onMaster(ompt_scope_endpoint_t _endpoint,
41+
static void onMasked(ompt_scope_endpoint_t _endpoint,
4242
ompt_data_t* parallelData,
4343
ompt_data_t* taskData,
4444
void const* codeptr) {
@@ -60,12 +60,21 @@ namespace opdi {
6060
protected:
6161

6262
static void init() {
63-
OPDI_CHECK_ERROR(CallbacksBase::registerCallback(ompt_callback_master,
64-
(ompt_callback_t) MasterCallbacks::onMaster));
63+
#if _OPENMP >= 202011
64+
OPDI_CHECK_ERROR(CallbacksBase::registerCallback(ompt_callback_masked,
65+
(ompt_callback_t) MaskedCallbacks::onMasked));
66+
#else
67+
OPDI_CHECK_ERROR(CallbacksBase::registerCallback(ompt_callback_master,
68+
(ompt_callback_t) MaskedCallbacks::onMasked));
69+
#endif
6570
}
6671

6772
static void finalize() {
68-
OPDI_CHECK_ERROR(CallbacksBase::clearCallback(ompt_callback_master));
73+
#if _OPENMP >= 202011
74+
OPDI_CHECK_ERROR(CallbacksBase::clearCallback(ompt_callback_masked));
75+
#else
76+
OPDI_CHECK_ERROR(CallbacksBase::clearCallback(ompt_callback_master));
77+
#endif
6978
}
7079

7180
};

include/opdi/backend/ompt/omptBackend.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
#include "implicitTaskCallbacks.hpp"
4646
#include "macros.hpp"
47-
#include "masterCallbacks.hpp"
47+
#include "maskedCallbacks.hpp"
4848
#include "mutexCallbacks.hpp"
4949
#include "parallelCallbacks.hpp"
5050
#include "reductionCallbacks.hpp"
@@ -55,7 +55,7 @@
5555
namespace opdi {
5656

5757
struct OmptBackend : public ImplicitTaskCallbacks,
58-
public MasterCallbacks,
58+
public MaskedCallbacks,
5959
public MutexCallbacks,
6060
public ParallelCallbacks,
6161
public ReductionCallbacks,
@@ -108,7 +108,7 @@ namespace opdi {
108108
MutexCallbacks::init();
109109
ReductionCallbacks::init();
110110
#if OPDI_BACKEND_GENERATE_MASKED_EVENTS
111-
MasterCallbacks::init();
111+
MaskedCallbacks::init();
112112
#endif
113113

114114
return 1; // success
@@ -120,7 +120,7 @@ namespace opdi {
120120

121121
// finalize callback structures
122122
#if OPDI_BACKEND_GENERATE_MASKED_EVENTS
123-
MasterCallbacks::finalize();
123+
MaskedCallbacks::finalize();
124124
#endif
125125
ReductionCallbacks::finalize();
126126
MutexCallbacks::finalize();

0 commit comments

Comments
 (0)