fix(logging): Replace printStackTrace() with proper logging, thx to hobostay #850

#850

Author: TommyLemon

APIJSONORM/src/main/java/apijson/orm/AbstractParser.java

@@ -590,7 +590,7 @@ public M parseResponse(M request) {
 			onCommit();
 		}
 		catch (Exception e) {
-			e.printStackTrace();
+			Log.e(TAG, "onObjectParse failed", e);
 			error = e;
 
 			onRollback();
@@ -1022,9 +1022,7 @@ public M newErrorResult(Exception e) {
 	 */
 	public M newErrorResult(Exception e, boolean isRoot) {
 		if (e != null) {
-		  	//      if (Log.DEBUG) {
-		  	e.printStackTrace();
-		  	//      }
+		  	Log.e(TAG, "newErrorResult", e);
 
 		  	String msg = CommonException.getMsg(e);
 			int code = CommonException.getCode(e);
@@ -1921,7 +1919,7 @@ public static <V extends Object> V getValue(Object parent, String[] pathKeys) {
 				v = getFromObjOrArr(v, k);
 			} catch (Throwable e) {
 				if (IS_PRINT_BIG_LOG) {
-					e.printStackTrace();
+					Log.e(TAG, "getFromObjOrArr failed", e);
 				}
 				v = null;
 			}
@@ -2230,7 +2228,7 @@ && getSQLExecutor().getTransactionIsolation() == Connection.TRANSACTION_NONE) {
 			commit();
 		}
 		catch (SQLException e) {
-			e.printStackTrace();
+			Log.e(TAG, "onCommit failed", e);
 		}
 	}
 	/**回滚事务
@@ -2245,12 +2243,12 @@ protected void onRollback() {
 			rollback();
 		}
 		catch (SQLException e1) {
-			e1.printStackTrace();
+			Log.e(TAG, "onRollback failed", e1);
 			try {
 				rollback(null);
 			}
 			catch (SQLException e2) {
-				e2.printStackTrace();
+				Log.e(TAG, "onRollback with null failed", e2);
 			}
 		}
 	}
@@ -2517,7 +2515,7 @@ protected M batchVerify(RequestMethod method, String tag, int version, String na
 					correctRequest.put(key, obj);
 				}
 			} catch (Exception e) {
-				e.printStackTrace();
+				Log.e(TAG, "parseCorrectRequest failed", e);
 				throw new Exception(e); // 包装一层只是为了打印日志？看起来没必要
 			}
 		}

APIJSONORM/src/main/java/apijson/orm/AbstractSQLExecutor.java

@@ -676,7 +676,7 @@ else if (hasPK) {
 					rs.close();
 				}
 				catch (Exception e) {
-					e.printStackTrace();
+					Log.e(TAG, "close ResultSet failed", e);
 				}
 			}
 		}
@@ -947,7 +947,7 @@ protected void executeAppJoin(SQLConfig<T, M, L> config, List<M> resultList, Map
 							rs.close();
 						}
 						catch (Exception e) {
-							e.printStackTrace();
+							Log.e(TAG, "close ResultSet failed in executeAppJoin", e);
 						}
 					}
 				}
@@ -1125,7 +1125,7 @@ else if (value instanceof Clob) { //SQL Server TEXT 类型 居然走这个
 				br.close();
 			}
 			catch (Exception e) {
-				e.printStackTrace();
+				Log.e(TAG, "close BufferedReader failed", e);
 			}
 		}
 
@@ -1194,7 +1194,7 @@ public boolean isJSONType(@NotNull SQLConfig<T, M, L> config, ResultSetMetaData
 				return true;
 			}
 		} catch (SQLException e) {
-			e.printStackTrace();
+			Log.e(TAG, "isJsonColumn failed", e);
 		}
 		//		List<String> json = config.getJson();
 		//		return json != null && json.contains(label);
@@ -1357,7 +1357,7 @@ public void begin(int transactionIsolation) throws SQLException {
 					}
 				}
 				catch (SQLException e) {
-					e.printStackTrace();
+					Log.e(TAG, "setAutoCommit failed in rollback", e);
 				}
 			}
 		}
@@ -1384,7 +1384,7 @@ public void rollback() throws SQLException {
 					}
 				}
 				catch (SQLException e) {
-					e.printStackTrace();
+					Log.e(TAG, "rollback failed", e);
 				}
 			}
 		}
@@ -1416,7 +1416,7 @@ public void rollback(Savepoint savepoint) throws SQLException {
 					}
 				}
 				catch (SQLException e) {
-					e.printStackTrace();
+					Log.e(TAG, "rollback with savepoint failed", e);
 				}
 			}
 		}
@@ -1442,7 +1442,7 @@ public void commit() throws SQLException {
 					}
 				}
 				catch (SQLException e) {
-					e.printStackTrace();
+					Log.e(TAG, "commit failed", e);
 				}
 			}
 		}
@@ -1473,7 +1473,7 @@ public void close() {
 					}
 				}
 				catch (SQLException e) {
-					e.printStackTrace();
+					Log.e(TAG, "close connection failed", e);
 				}
 			}
 		}

APIJSONORM/src/main/java/apijson/orm/JSONRequest.java

@@ -99,7 +99,7 @@ public Object put(String key, Object value) {
             target = JSON.parse(value);
         } catch (Exception e) {
             // nothing
-			e.printStackTrace();
+			Log.e(TAG, "JSON.parse failed for key: " + key, e);
         }
         //		if (target == null) { // "tag":"User" 报错
 		//			return null;

APIJSONORM/src/main/java/apijson/orm/script/JSR223ScriptExecutor.java

@@ -12,6 +12,7 @@
 import javax.script.ScriptEngineManager;
 import javax.script.SimpleBindings;
 
+import apijson.Log;
 import apijson.orm.AbstractFunctionParser;
 
 /**
@@ -45,7 +46,7 @@ public void load(String name, String script) {
 			CompiledScript compiledScript = ((Compilable) scriptEngine).compile(convertScript(script));
 			compiledScriptMap.put(name, compiledScript);
 		} catch (Exception e) {
-			e.printStackTrace();
+			Log.e(TAG, "compile script failed: " + name, e);
 		}
 
 	}