Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenROAD into secure-jhkim-test

Author: jhkim-pii

MODULE.bazel

@@ -151,7 +151,7 @@ bazel_dep(name = "bazel-orfs")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 git_override(
     module_name = "bazel-orfs",
-    commit = "f8e4ced47dc2c9d15aea97d734eba55a50f35666",
+    commit = "72078ddd575513b35bd3cdfdb5c115949fc44e97",
     remote = "https://github.com/The-OpenROAD-Project/bazel-orfs.git",
 )
 
@@ -160,10 +160,10 @@ orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 orfs.default(
     # Official image https://hub.docker.com/r/openroad/orfs/tags
-    image = "docker.io/openroad/orfs:v3.0-3444-g669e62e5",
+    image = "docker.io/openroad/orfs:v3.0-3455-g9638e97b",
     # Use OpenROAD of this repo instead of from the docker image
     openroad = "//:openroad",
-    sha256 = "9f9c6c0817eba504c56cdf613bf1bcc00054164500a276de894a4cb1f48b69a6",
+    sha256 = "7d6478d96c474f29f21e700f723d30b70d44e88686c3801688a22b35c35698e7",
 )
 use_repo(orfs, "com_github_nixos_patchelf_download")
 use_repo(orfs, "docker_orfs")

MODULE.bazel.lock

@@ -32,6 +32,8 @@ B=${0%%.cc}; [ "$B" -nt "$0" ] || c++ -std=c++17 -o"$B" "$0" && exec "$B" "$@";
 //  CLANG_TIDY_CONFIG  = override configuration file in kConfig.clang_tidy_file
 //  CACHE_DIR          = where to put the cached content; default ~/.cache
 //  CLANG_TIDY_JOBS    = Number of tasks to run in parallel.
+//  COMPILE_JSON       = where to find cmake compile commands;
+//                       default build/compile_commands.json
 
 // This file shall be c++17 self-contained; not using any re2 or absl niceties.
 #include <unistd.h>
@@ -282,7 +284,8 @@ class ClangTidyRunner
   // Given a work-queue in/out-file, process it. Using system() for portability.
   // Empties work_queue.
   void RunClangTidyOn(ContentAddressedStore& output_store,
-                      std::list<filepath_contenthash_t>* work_queue)
+                      std::list<filepath_contenthash_t>* work_queue,
+                      std::string_view compile_json_str)
   {
     if (work_queue->empty()) {
       return;
@@ -319,9 +322,10 @@ class ClangTidyRunner
         const std::string tmp_out = final_out.string() + uniquifier + ".tmp";
         // Putting the file to clang-tidy early in the command line so that
         // it is easy to find with `ps` or `top`.
-        const std::string command = clang_tidy_ + " '" + work.first.string()
-                                    + "'" + clang_tidy_args_ + "> '" + tmp_out
-                                    + "' 2>/dev/null";
+        const std::string command
+            = clang_tidy_ + " -p " + std::string(compile_json_str) + " '"
+              + work.first.string() + "'" + clang_tidy_args_ + "> '" + tmp_out
+              + "' 2>/dev/null";
         const int r = system(command.c_str());
 #ifdef WIFSIGNALED
         // NOLINTBEGIN
@@ -629,14 +633,15 @@ int main(int argc, char* argv[])
     return EXIT_FAILURE;
   }
 
-  auto compdb_ts = fs::last_write_time("compile_commands.json", ec);
+  std::string_view compile_json_str
+      = EnvWithFallback("COMPILE_JSON", "build/compile_commands.json");
+  auto compdb_ts = fs::last_write_time(compile_json_str, ec);
   if (ec.value() != 0) {
     compdb_ts = fs::last_write_time("compile_flags.txt", ec);
   }
   if (ec.value() != 0) {
-    std::cerr << "No compilation db compile_commands.json or compile_flags.txt "
-              << "found; create that first. For cmake projects, often simply\n"
-              << "\tln -s build/compile_commands.json .\n";
+    std::cerr << "No compilation db " << compile_json_str
+              << " found; create that first.\n";
     return EXIT_FAILURE;
   }
 
@@ -655,7 +660,7 @@ int main(int argc, char* argv[])
   auto work_list = cc_file_gatherer.BuildWorkList(build_env_latest_change);
 
   // Now the expensive part...
-  runner.RunClangTidyOn(store, &work_list);
+  runner.RunClangTidyOn(store, &work_list, compile_json_str);
 
   const std::string detailed_report = cache_prefix + "clang-tidy.out";
   const std::string summary = cache_prefix + "clang-tidy.summary";

etc/run-clang-tidy-cached.cc

@@ -734,6 +734,9 @@ proc set_io_pin_constraint { args } {
       } elseif { $interval == "*" } {
         set begin [ppl::get_edge_extreme "-region" 1 $edge]
         set end [ppl::get_edge_extreme "-region" 0 $edge]
+      } else {
+        utl::error PPL 212 "Invalid value for \'-region edge:interval\'. Set the interval as the\
+                wildcard \'*\' or as a range \'begin-end\' in microns."
       }
 
       if { [info exists keys(-direction)] && [info exists keys(-pin_names)] } {

src/odb/src/swig/tcl/odb.tcl

@@ -79,7 +79,7 @@ set_io_pin_constraint
 | ----- | ----- |
 | `-direction` | Pin direction (`input`, `output`, `inout`, or `feedthrough`). |
 | `-pin_names` | List of names. Only one of (`-direction`, `-pin_names`) should be used in a single call for the `set_io_pin_constraint` command. |
-| `-region` | Syntax is `-region edge:interval`. The `edge` values are (`top\|bottom\|left\|right`). The `interval` can be the whole edge with the wildcard `*` value or a range of values. |
+| `-region` | Syntax is `-region edge:interval`. The `edge` values are (`top\|bottom\|left\|right`). The `interval` can be the whole edge with the wildcard `*` value or a range of values `begin-end` in microns. For example, in `-region right:15-60` the interval is on the right edge from 15 microns to 60 microns.|
 | `-mirrored_pins` | List of pins that sets pairs of pins that will be symmetrically placed in the vertical or the horizontal edges. The number of pins in this list **must be even**. For example, in `set_io_pin_constraint -mirrored_pins {pin1 pin2 pin3 pin4 pin5 pin6}`, the pins `pin1` and `pin2` will be placed symmetrically to each other. Same for `pin3` and `pin4`, and for `pin5` and `pin6`. |
 | `-group` | Flag places together on the die boundary the pin list defined in `-pin_names,` similar to the `-group_pins` option on the `place_pins` command. |
 | `-order` | Flag places the pins ordered in ascending x/y position and must be used only when `-group` is also used. |

src/ppl/README.md

@@ -30,6 +30,7 @@ or_integration_tests(
     add_constraint_error7
     add_constraint_error8
     add_constraint_error9
+    add_constraint_error10
     annealing1
     annealing2
     annealing3

src/ppl/test/CMakeLists.txt

@@ -0,0 +1,7 @@
+[INFO ODB-0227] LEF file: Nangate45/Nangate45.lef, created 22 layers, 27 vias, 135 library cells
+[INFO ODB-0128] Design: gcd
+[INFO ODB-0130]     Created 54 pins.
+[INFO ODB-0131]     Created 88 components and 422 component-terminals.
+[INFO ODB-0133]     Created 54 nets and 88 connections.
+[ERROR PPL-0212] Invalid value for '-region edge:interval'. Set the interval as the wildcard '*' or as a range 'begin-end' in microns.
+PPL-0212

src/ppl/test/add_constraint_error10.ok

@@ -0,0 +1,10 @@
+# gcd_nangate45 IO placement
+source "helpers.tcl"
+read_lef Nangate45/Nangate45.lef
+read_def gcd.def
+
+catch {
+  set_io_pin_constraint -group -order -region left:90.3 -pin_names {resp_msg[0] req_msg[0]
+  resp_msg[1] req_msg[1] resp_msg[2] req_msg[2] resp_msg[3]}
+} error
+puts $error

src/ppl/test/add_constraint_error10.tcl

@@ -171,8 +171,6 @@ orfs_flow(
     abstract_stage = POWER_STAGE_NAME,
     arguments = {
         "PLACE_DENSITY": "0.82",
-        "MOCK_ARRAY_ROWS": "8",
-        "MOCK_ARRAY_COLS": "8",
         "DETAILED_ROUTE_END_ITERATION": "6",
         "MIN_ROUTING_LAYER": "M2",
         "MAX_ROUTING_LAYER": "M5",