Merge remote-tracking branch 'origin/master' into gpl_remove_filler_removal_cap

Author: LucasYuki

.clang-tidy

@@ -8,7 +8,7 @@ Checks: >
   -clang-analyzer-cplusplus.NewDeleteLeaks,
   -clang-analyzer-optin.performance.Padding,
   readability-*,
-  -readability-identifier-naming
+  -readability-identifier-naming,
   -readability-braces-around-statements,
   -readability-convert-member-functions-to-static,
   -readability-function-cognitive-complexity,

.github/dependabot.yml

@@ -4,7 +4,3 @@ updates:
     directory: "/"
     schedule:
       interval: "daily"
-  - package-ecosystem: "gitsubmodule"
-    directory: "/"
-    schedule:
-      interval: "daily"

.github/workflows/github-actions-clang-tidy.yml

@@ -17,6 +17,7 @@ jobs:
         uses: The-OpenROAD-Project/clang-tidy-review@master
         id: review
         with:
+          clang_tidy_version: 19
           build_dir: "./build"
           cmake_command: cmake . -B build
           config_file: ".clang-tidy"

BUILD.bazel

@@ -49,7 +49,6 @@ config_setting(
 
 OPENROAD_LIBRARY_DEPS = [
     ":openroad_version",
-    ":ord",
     "//src/ant",
     "//src/ant:ui",
     "//src/cgt",
@@ -106,6 +105,7 @@ OPENROAD_LIBRARY_DEPS = [
     "//src/utl",
     "//src/utl:ui",
     "@edu_berkeley_abc//:abc-lib",
+    ":ord",
 ] + select(
     {
         ":platform_cli": ["//src/gui"],
@@ -187,11 +187,11 @@ cc_library(
         "include",
     ],
     visibility = ["//visibility:public"],
-    deps = OPENROAD_LIBRARY_DEPS + [
+    deps = [
         "//src/sta:opensta_lib",
         "@boost.stacktrace",
         "@tk_tcl//:tcl",
-    ],
+    ] + OPENROAD_LIBRARY_DEPS,
 )
 
 cc_library(

Jenkinsfile

@@ -217,28 +217,33 @@ def bazelTest = {
             checkout scm;
             sh label: 'Setup Docker Image', script: 'docker build -f docker/Dockerfile.bazel -t openroad/bazel-ci .';
         }
-        withDockerContainer(args: '-u root -v /var/run/docker.sock:/var/run/docker.sock', image: 'openroad/bazel-ci:latest') {
-            stage('bazelisk test ...') {
-                withCredentials([string(credentialsId: 'bazel-auth-token-b64', variable: 'BAZEL_AUTH_TOKEN_B64')]) {
-                    timeout(time: 120, unit: 'MINUTES') {
-                        def cmd = 'bazelisk test --config=ci --show_timestamps --test_output=errors --curses=no --force_pic --remote_header="Authorization=Basic $BAZEL_AUTH_TOKEN_B64" --profile=build.profile'
-                        try {
-                            try {
-                                sh label: 'Test, using cached results and building a minimum of dependencies', script: cmd + ' ...';
-                            } finally {
-                                sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
-                            }
-                        } catch (e) {
-                            currentBuild.result = 'FAILURE';
+        try {
+            withDockerContainer(args: '-u root -v /var/run/docker.sock:/var/run/docker.sock', image: 'openroad/bazel-ci:latest') {
+                stage('bazelisk test ...') {
+                    withCredentials([string(credentialsId: 'bazel-auth-token-b64', variable: 'BAZEL_AUTH_TOKEN_B64')]) {
+                        timeout(time: 120, unit: 'MINUTES') {
+                            def cmd = 'bazelisk test --config=ci --show_timestamps --test_output=errors --curses=no --force_pic --remote_header="Authorization=Basic $BAZEL_AUTH_TOKEN_B64" --profile=build.profile'
                             try {
-                                sh label: 'Test (keep_going)', script: cmd + ' --keep_going ...';
-                            } finally {
-                                sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                                try {
+                                    sh label: 'Test, using cached results and building a minimum of dependencies', script: cmd + ' ...';
+                                } finally {
+                                    sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                                }
+                            } catch (e) {
+                                try {
+                                    sh label: 'Test (keep_going)', script: cmd + ' --keep_going ...';
+                                } catch (e2) {
+                                    currentBuild.result = 'FAILURE';
+                                } finally {
+                                    sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                                }
                             }
                         }
                     }
                 }
             }
+        } catch (IOException e) {
+            echo "Caught: ${e}";
         }
     }
 }

MODULE.bazel

@@ -153,7 +153,7 @@ bazel_dep(name = "bazel-orfs")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 git_override(
     module_name = "bazel-orfs",
-    commit = "da01065203fbcc043c82318b544fbe111053b9d0",
+    commit = "2aa6a9dd3c0006c5358e363fcac9e209c4dccc47",
     remote = "https://github.com/The-OpenROAD-Project/bazel-orfs.git",
 )
 
@@ -162,10 +162,10 @@ orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 orfs.default(
     # Official image https://hub.docker.com/r/openroad/orfs/tags
-    image = "docker.io/openroad/orfs:v3.0-3872-g66e441c6c",
+    image = "docker.io/openroad/orfs:v3.0-3998-gb31abb52d",
     # Use OpenROAD of this repo instead of from the docker image
     openroad = "//:openroad",
-    sha256 = "f75321f10023a8bf99b1ed5dfe1dab6351f588eda24f186a66e9145fd9b76fd1",
+    sha256 = "dc40b4a466dcc394b542f2189422ca1c5480c223926fd7a6844211e23a129117",
 )
 use_repo(orfs, "com_github_nixos_patchelf_download")
 use_repo(orfs, "docker_orfs")