Merge pull request #8617 from gadfort/pdn-warn-on-partial-overlap

pdn: error on complete pin coverage and warn on partial coverage

Author: maliberty

src/pdn/src/grid.cpp

@@ -5,6 +5,7 @@
 
 #include <algorithm>
 #include <array>
+#include <cstdint>
 #include <map>
 #include <memory>
 #include <set>
@@ -1697,6 +1698,8 @@ void InstanceGrid::checkSetup() const
 
     if (top != nullptr) {
       const int top_idx = top->getNumber();
+      std::map<odb::Rect, int64_t> overlap_area;
+      std::set<odb::dbTechLayer*> layers;
       for (auto* master_obs : inst_->getMaster()->getObstructions()) {
         auto* obs_layer = master_obs->getTechLayer();
         if (obs_layer == nullptr) {
@@ -1707,18 +1710,57 @@ void InstanceGrid::checkSetup() const
         }
         if (obs_layer->getNumber() > top_idx) {
           for (const auto& pin : boxes) {
-            if (pin.intersects(master_obs->getBox())) {
-              getLogger()->error(
-                  utl::PDN,
-                  6,
-                  "Pins on {} are blocked by obstructions on {} for {}",
-                  top->getName(),
-                  obs_layer->getName(),
-                  inst_->getName());
+            const odb::Rect mobs = master_obs->getBox();
+
+            if (mobs.intersects(pin)) {
+              // Determine level of obstruction
+              const odb::Rect overlap = mobs.intersect(pin);
+              overlap_area[pin] += overlap.area();
+              layers.insert(obs_layer);
             }
           }
         }
       }
+
+      if (!overlap_area.empty()) {
+        int64_t total_pin_area = 0;
+        int64_t total_overlap = 0;
+        std::string layer_txt;
+        for (const auto* layer : layers) {
+          if (!layer_txt.empty()) {
+            layer_txt += ", ";
+          }
+          layer_txt += layer->getName();
+        }
+        for (const auto& [pin, overlap] : overlap_area) {
+          const int64_t pinarea = pin.area();
+          total_overlap += overlap;
+          total_pin_area += pinarea;
+
+          if (overlap >= pinarea) {
+            // pin completely obstructed
+            getLogger()->error(
+                utl::PDN,
+                6,
+                "{} on {} is blocked by obstructions on {} for {}",
+                iterm->getMTerm()->getName(),
+                top->getName(),
+                layer_txt,
+                inst_->getName());
+          }
+        }
+        const float pct
+            = 100 * static_cast<float>(total_overlap) / total_pin_area;
+        getLogger()->warn(utl::PDN,
+                          7,
+                          "{} on {} is partially blocked ({:.1f}%) by "
+                          "obstructions on {} for {}",
+                          iterm->getMTerm()->getName(),
+                          top->getName(),
+                          pct,
+                          layer_txt,
+                          inst_->getName());
+      }
     }
   }
 }

src/pdn/test/BUILD

@@ -7,6 +7,7 @@ COMPULSORY_TESTS = [
     "add_double_global_connection",
     "asap7_failed_macro_covered",
     "asap7_failed_macro_grid",
+    "asap7_macro_covered_partial",
     "asap7_no_via_generate",
     "asap7_no_via_generate_v1_snapped",
     "asap7_offcenter_via",
@@ -183,6 +184,7 @@ filegroup(
         "Nangate45_vias/Nangate45_adjacentcuts.lef",
         "asap7_data/fakeram7_256x32.lef",
         "asap7_data/fakeram7_256x32_covered.lef",
+        "asap7_data/fakeram7_256x32_covered_partial.lef",
         "asap7_data/fakeram7_256x32_notcovered.lef",
         "asap7_vias/asap7_tech_1x.lef",
         "asap7_vias/asap7_tech_1x_arrayspacing.lef",
@@ -278,6 +280,7 @@ filegroup(
             ],
         ) + {
             "asap7_failed_macro_covered": ["asap7_failed_macro_grid.def"],
+            "asap7_macro_covered_partial": ["asap7_failed_macro_grid.def"],
             "asap7_macro_notcovered": ["asap7_failed_macro_grid.def"],
             "core_grid_auto_domain": ["core_grid.defok"],
             "core_grid_with_rings_connect": ["core_grid_with_rings.defok"],

src/pdn/test/CMakeLists.txt

@@ -4,6 +4,7 @@ or_integration_tests(
     add_double_global_connection
     asap7_failed_macro_covered
     asap7_failed_macro_grid
+    asap7_macro_covered_partial
     asap7_no_via_generate
     asap7_no_via_generate_v1_snapped
     asap7_offcenter_via

src/pdn/test/asap7_data/fakeram7_256x32_covered.lef

@@ -879,7 +879,7 @@ MACRO fakeram7_256x32
     LAYER M4 ;
     RECT 0.1 0 4.080 67.200 ;
     LAYER M5 ;
-    RECT 0.1 0 4.080 67.200 ;
+    RECT 0.048 0 4.132 67.200 ;
   END
 END fakeram7_256x32