Skip to content

Commit 78fa7e7

Browse files
committed
Fixed right click based on wrong vtable, added more documentation to STA types
Signed-off-by: Ethan Mahintorabi <ethanmoon@google.com>
1 parent dc8b2b3 commit 78fa7e7

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ bazel_dep(name = "zlib", version = "1.3.1.bcr.5")
108108
bazel_dep(name = "qt-bazel")
109109
git_override(
110110
module_name = "qt-bazel",
111-
commit = "69398ecac8d66587d1bc31a4bc46084ba34b161a",
111+
commit = "90cfbab79df93960c5493f8a75df6199fb80fe26",
112112
remote = "https://github.com/The-OpenROAD-Project/qt_bazel_prebuilts",
113113
)
114114

src/dbSta/include/db_sta/dbSta.hh

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,29 +26,43 @@ namespace sta {
2626
// talking to the OpenSTA author about implementing these
2727
// upstream instead. https://github.com/llvm/llvm-project/issues/36746
2828
// for llvm bug.
29+
//
30+
// Deleting all the constructors to preserve behavior as opaque pointers.
31+
// This should let RTTI based constructs like std::any to work on these
32+
// types. See
33+
// https://github.com/The-OpenROAD-Project/OpenROAD/pull/7725#discussion_r2201423922
34+
// for more information.
2935
class Library
3036
{
37+
Library() = delete;
3138
};
3239
class Cell
3340
{
41+
Cell() = delete;
3442
};
3543
class Port
3644
{
45+
Port() = delete;
3746
};
3847
class Instance
3948
{
49+
Instance() = delete;
4050
};
4151
class Pin
4252
{
53+
Pin() = delete;
4354
};
4455
class Term
4556
{
57+
Term() = delete;
4658
};
4759
class Net
4860
{
61+
Net() = delete;
4962
};
5063
class ViewType
5164
{
65+
ViewType() = delete;
5266
};
5367

5468
class dbSta;

0 commit comments

Comments
 (0)