Skip to content

Commit 85aba71

Browse files
authored
Merge pull request #8643 from LucasYuki/gui_fix_through_in_timing_widget
gui: fix "through" filter in the timing widget
2 parents cafb53b + ea5ed35 commit 85aba71

3 files changed

Lines changed: 9 additions & 0 deletions

File tree

src/gui/src/dropdownCheckboxes.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
#pragma once
55

66
#include <qchar.h>
7+
#include <qnamespace.h>
78
#include <qobjectdefs.h>
89

910
#include <QComboBox>
@@ -48,6 +49,7 @@ class DropdownCheckboxes : public QComboBox
4849
QStandardItem* getAllItem() { return all_item_; };
4950

5051
QStandardItemModel* model() { return model_; };
52+
bool isAllSelected() { return all_item_->checkState() == Qt::Checked; };
5153
std::vector<QString> selectedItems();
5254

5355
public slots:

src/gui/src/staGui.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1364,6 +1364,12 @@ std::vector<std::set<const sta::Pin*>> TimingControlsDialog::getThruPins() const
13641364

13651365
const sta::ClockSet* TimingControlsDialog::getClocks()
13661366
{
1367+
if (clock_box_->isAllSelected()) {
1368+
// returns nullptr if all clocks are selected,
1369+
// so the STA doesn't need to filter by clock
1370+
return nullptr;
1371+
}
1372+
13671373
selected_clocks_.clear();
13681374
for (const auto& clk_name : clock_box_->selectedItems()) {
13691375
selected_clocks_.insert(qstring_to_clk_[clk_name]);

src/gui/src/staGuiInterface.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,6 +1095,7 @@ TimingPathList STAGuiInterface::getTimingPaths(
10951095
pins, nullptr, nullptr, sta::RiseFallBoth::riseFall()));
10961096
}
10971097
}
1098+
10981099
sta::ExceptionTo* e_to = nullptr;
10991100
if (!to.empty()) {
11001101
sta::PinSet* pins = new sta::PinSet(getNetwork());

0 commit comments

Comments
 (0)