Merge pull request #8489 from osamahammad21/3dblox-lib

ODB: read liberty from 3dblox files

Author: osamahammad21

src/OpenRoad.cc

@@ -485,13 +485,13 @@ void OpenRoad::writeCdl(const char* out_filename,
 
 void OpenRoad::read3Dbv(const std::string& filename)
 {
-  odb::ThreeDBlox parser(logger_, db_);
+  odb::ThreeDBlox parser(logger_, db_, sta_);
   parser.readDbv(filename);
 }
 
 void OpenRoad::read3Dbx(const std::string& filename)
 {
-  odb::ThreeDBlox parser(logger_, db_);
+  odb::ThreeDBlox parser(logger_, db_, sta_);
   parser.readDbx(filename);
 }
 

src/odb/BUILD

@@ -70,6 +70,7 @@ cc_library(
         "//src/odb/src/def:defzlib",
         "//src/odb/src/lef",
         "//src/odb/src/lef:lefzlib",
+        "//src/sta:opensta_lib",
         "//src/utl",
         "@boost.algorithm",
         "@boost.bind",

src/odb/include/odb/3dblox.h

@@ -9,7 +9,9 @@
 namespace utl {
 class Logger;
 }
-
+namespace sta {
+class Sta;
+}
 namespace odb {
 class dbDatabase;
 class ChipletDef;
@@ -24,7 +26,7 @@ class dbChipInst;
 class ThreeDBlox
 {
  public:
-  ThreeDBlox(utl::Logger* logger, odb::dbDatabase* db);
+  ThreeDBlox(utl::Logger* logger, odb::dbDatabase* db, sta::Sta* sta = nullptr);
   ~ThreeDBlox() = default;
   void readDbv(const std::string& dbv_file);
   void readDbx(const std::string& dbx_file);
@@ -42,5 +44,6 @@ class ThreeDBlox
 
   utl::Logger* logger_ = nullptr;
   odb::dbDatabase* db_ = nullptr;
+  sta::Sta* sta_ = nullptr;
 };
 }  // namespace odb

src/odb/src/3dblox/3dblox.cpp

@@ -18,6 +18,7 @@
 #include "odb/defin.h"
 #include "odb/geom.h"
 #include "odb/lefin.h"
+#include "sta/Sta.hh"
 #include "utl/Logger.h"
 
 namespace odb {
@@ -32,8 +33,8 @@ static std::map<std::string, std::string> dup_orient_map
        {"MZ_MX_R180", "MZ_MY"},
        {"MZ_MX_R270", "MZ_MY_R90"}};
 
-ThreeDBlox::ThreeDBlox(utl::Logger* logger, odb::dbDatabase* db)
-    : logger_(logger), db_(db)
+ThreeDBlox::ThreeDBlox(utl::Logger* logger, odb::dbDatabase* db, sta::Sta* sta)
+    : logger_(logger), db_(db), sta_(sta)
 {
 }
 
@@ -157,7 +158,12 @@ void ThreeDBlox::createChiplet(const ChipletDef& chiplet)
     odb::lefin lef_reader(db_, logger_, false);
     lef_reader.createLib(tech, lib_name.c_str(), lef_file.c_str());
   }
-  // TODO: Read liberty files
+  if (sta_ != nullptr) {
+    for (const auto& liberty_file : chiplet.external.lib_files) {
+      sta_->readLiberty(
+          liberty_file.c_str(), sta_->cmdCorner(), sta::MinMaxAll::all(), true);
+    }
+  }
   // Check if chiplet already exists
   auto chip = db_->findChip(chiplet.name.c_str());
   if (chip != nullptr) {

src/odb/src/3dblox/CMakeLists.txt

@@ -15,6 +15,7 @@ target_link_libraries(3dblox
     db
     utl_lib
     yaml-cpp
+    OpenSTA
 )
 
 target_include_directories(3dblox

src/odb/test/data/example.3dbv

@@ -29,10 +29,7 @@ ChipletDef:
           - [955, 1082]
           - [0, 1082]
     external:
-      thermal_name: [N5_1P15M]
       APR_tech_file: [NG45_PATH/*_tech.lef]
-      RC_tech_file: [Collateral/SoC/tech/a.ircx]
-      liberty_file: [Collateral/SoC/lib/a.lib]
-      3dbf_file: [Feasibility/SoC.3dbf]
+      liberty_file: [NG45_PATH/fake_macros.lib]
       LEF_file: [NG45_PATH/fake_macros.lef]
       DEF_file: ../fake_macros.def

src/odb/test/read_3dbv.ok

@@ -1,5 +1,6 @@
 [INFO ODB-0227] LEF file: data/../Nangate45/Nangate45_tech.lef, created 22 layers, 27 vias
 [INFO ODB-0227] LEF file: data/../Nangate45/fake_macros.lef, created 10 library cells
+[WARNING STA-1171] data/../Nangate45/fake_macros.lib line 32, default_max_transition is 0.0.
 [INFO ODB-0128] Design: fake_macros
 [INFO ODB-0131]     Created 10 components and 32 component-terminals.
 [INFO ODB-0133]     Created 12 nets and 24 connections.

src/odb/test/read_3dbv.tcl

@@ -1,7 +1,6 @@
 source "helpers.tcl"
 
 set db [ord::get_db]
-set tech [odb::dbTech_create $db "tech"]
 
 read_3dbv "data/example.3dbv"
 if { [$db getChip] == "NULL" } {

src/odb/test/read_3dbx.ok

@@ -1,5 +1,6 @@
 [INFO ODB-0227] LEF file: data/../Nangate45/Nangate45_tech.lef, created 22 layers, 27 vias
 [INFO ODB-0227] LEF file: data/../Nangate45/fake_macros.lef, created 10 library cells
+[WARNING STA-1171] data/../Nangate45/fake_macros.lib line 32, default_max_transition is 0.0.
 [INFO ODB-0128] Design: fake_macros
 [INFO ODB-0131]     Created 10 components and 32 component-terminals.
 [INFO ODB-0133]     Created 12 nets and 24 connections.

src/odb/test/read_3dbx.tcl

@@ -1,7 +1,6 @@
 source "helpers.tcl"
 
 set db [ord::get_db]
-set tech [odb::dbTech_create $db "tech"]
 
 read_3dbx "data/example.3dbx"
 if { [$db getChip] == "NULL" } {