Skip to content

Commit 973d489

Browse files
committed
gui: guard against empty gif generation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
1 parent 21008b8 commit 973d489

1 file changed

Lines changed: 13 additions & 0 deletions

File tree

src/gui/src/gui.cpp

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1450,6 +1450,10 @@ void Gui::gifStart(const std::string& filename)
14501450
logger_->error(utl::GUI, 49, "Cannot generate GIF without GUI enabled");
14511451
}
14521452

1453+
if (filename.empty()) {
1454+
logger_->error(utl::GUI, 81, "Filename is required to save a GIF.");
1455+
}
1456+
14531457
gif_ = std::make_unique<GIF>();
14541458
gif_->filename = filename;
14551459
gif_->writer = nullptr;
@@ -1546,6 +1550,15 @@ void Gui::gifEnd()
15461550
return;
15471551
}
15481552

1553+
if (gif_->writer == nullptr) {
1554+
logger_->warn(utl::GUI,
1555+
75,
1556+
"Nothing to save to {}. No frames added to gif.",
1557+
gif_->filename);
1558+
gif_ = nullptr;
1559+
return;
1560+
}
1561+
15491562
GifEnd(gif_->writer.get());
15501563
gif_ = nullptr;
15511564
}

0 commit comments

Comments
 (0)