Implemented dbObject::isValid(). Changed default object name to "<type:oid>"

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>

Author: jhkim-pii

src/dbSta/src/dbNetwork.cc

@@ -140,17 +140,17 @@ PinInfo getPinInfo(const dbNetwork* network, const Pin* pin)
   if (iterm) {
     info.id = iterm->getId();
     info.type_name = iterm->getTypeName();
-    info.valid = dbITerm::isValid(iterm, network->block());
+    info.valid = iterm->isValid();
     info.addr = static_cast<void*>(iterm);
   } else if (bterm) {
     info.id = bterm->getId();
     info.type_name = bterm->getTypeName();
-    info.valid = dbBTerm::isValid(bterm, network->block());
+    info.valid = bterm->isValid();
     info.addr = static_cast<void*>(bterm);
   } else if (moditerm) {
     info.id = moditerm->getId();
     info.type_name = moditerm->getTypeName();
-    info.valid = dbModITerm::isValid(moditerm, network->block());
+    info.valid = moditerm->isValid();
     info.addr = static_cast<void*>(moditerm);
   }
 

src/odb/include/odb/db.h

@@ -1664,11 +1664,6 @@ class dbBTerm : public dbObject
   /// Return true if this BTerm is mirrored with another pin.
   ///
   bool isMirrored();
-
-  ///
-  /// Return true if the BTerm is allocated
-  ///
-  static bool isValid(const dbBTerm* bterm, const dbBlock* block);
 };
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -3342,11 +3337,6 @@ class dbITerm : public dbObject
   ///
   void clearPrefAccessPoints();
 
-  ///
-  /// Return true if the ITerm is allocated
-  ///
-  static bool isValid(const dbITerm* iterm, const dbBlock* block);
-
   ///
   /// Translate a database-id back to a pointer.
   ///
@@ -8326,11 +8316,6 @@ class dbModBTerm : public dbObject
   void setBusPort(dbBusPort*);
   dbBusPort* getBusPort() const;
 
-  ///
-  /// Return true if the dbModBTerm is allocated
-  ///
-  static bool isValid(const dbModBTerm* modbterm, const dbBlock* block);
-
   static dbModBTerm* create(dbModule* parentModule, const char* name);
   static void destroy(dbModBTerm*);
   static dbSet<dbModBTerm>::iterator destroy(dbSet<dbModBTerm>::iterator& itr);
@@ -8401,11 +8386,6 @@ class dbModITerm : public dbObject
   void connect(dbModNet* modnet);
   void disconnect();
 
-  ///
-  /// Return true if the dbModITerm is allocated
-  ///
-  static bool isValid(const dbModITerm* moditerm, const dbBlock* block);
-
   static dbModITerm* create(dbModInst* parentInstance,
                             const char* name,
                             dbModBTerm* modbterm = nullptr);

src/odb/include/odb/dbObject.h

@@ -166,6 +166,7 @@ class dbObject
   uint getId() const;
   const char* getTypeName() const;
   std::string getName() const;
+  bool isValid() const;
 
   static const char* getTypeName(dbObjectType type);
   static dbObjectType getType(const char* name, utl::Logger* logger);

src/odb/src/db/dbBTerm.cpp

@@ -1043,13 +1043,4 @@ bool dbBTerm::isMirrored()
   return bterm->_is_mirrored;
 }
 
-bool dbBTerm::isValid(const dbBTerm* bterm, const dbBlock* block)
-{
-  if (bterm == nullptr || block == nullptr) {
-    return false;
-  }
-  const _dbBlock* block_impl = (const _dbBlock*) block;
-  return block_impl->_bterm_tbl->validId(bterm->getId());
-}
-
 }  // namespace odb

src/odb/src/db/dbCore.h

@@ -172,6 +172,7 @@ class _dbObject : public dbObject
   dbObjectType getType() const;
   uint getOID() const;
   utl::Logger* getLogger() const;
+  bool isValid() const { return _oid & DB_ALLOC_BIT; };
 
  private:
   uint _oid;

src/odb/src/db/dbITerm.cpp

@@ -900,15 +900,6 @@ std::vector<std::pair<dbTechLayer*, Rect>> dbITerm::getGeometries() const
   return geometries;
 }
 
-bool dbITerm::isValid(const dbITerm* iterm, const dbBlock* block)
-{
-  if (iterm == nullptr || block == nullptr) {
-    return false;
-  }
-  const _dbBlock* block_impl = (const _dbBlock*) block;
-  return block_impl->_iterm_tbl->validId(iterm->getId());
-}
-
 void _dbITerm::collectMemInfo(MemInfo& info)
 {
   info.cnt++;

src/odb/src/db/dbModBTerm.cpp

@@ -524,15 +524,6 @@ dbSet<dbModBTerm>::iterator dbModBTerm::destroy(
   return next;
 }
 
-bool dbModBTerm::isValid(const dbModBTerm* modbterm, const dbBlock* block)
-{
-  if (modbterm == nullptr || block == nullptr) {
-    return false;
-  }
-  const _dbBlock* block_impl = (const _dbBlock*) block;
-  return block_impl->_modbterm_tbl->validId(modbterm->getId());
-}
-
 // User Code End dbModBTermPublicMethods
 }  // namespace odb
    // Generator Code End Cpp

src/odb/src/db/dbModITerm.cpp

@@ -459,15 +459,6 @@ dbSet<dbModITerm>::iterator dbModITerm::destroy(
   return next;
 }
 
-bool dbModITerm::isValid(const dbModITerm* moditerm, const dbBlock* block)
-{
-  if (moditerm == nullptr || block == nullptr) {
-    return false;
-  }
-  const _dbBlock* block_impl = (const _dbBlock*) block;
-  return block_impl->_moditerm_tbl->validId(moditerm->getId());
-}
-
 // User Code End dbModITermPublicMethods
 }  // namespace odb
    // Generator Code End Cpp

src/odb/src/db/dbObject.cpp

@@ -3,6 +3,8 @@
 
 #include "odb/dbObject.h"
 
+#include <spdlog/fmt/fmt.h>
+
 #include <cstdint>
 #include <cstring>
 #include <string>
@@ -452,10 +454,15 @@ std::string dbObject::getName() const
     case dbModInstObj:
       return static_cast<const dbModInst*>(this)->getName();
     default:
-      return "<no_name>";
+      return fmt::format("<{}:{}>", getTypeName(), getId());
   }
 }
 
+bool dbObject::isValid() const
+{
+  return getImpl()->isValid();
+}
+
 dbIStream& operator>>(dbIStream& stream, dbObjectType& type)
 {
   uint32_t hash;