Merge remote-tracking branch 'origin/master' into gpl_remove_filler_removal_cap

Author: LucasYuki

.gitignore

@@ -65,3 +65,4 @@ bazel-OpenROAD
 projectview.bazelproject
 .bsp/
 .bazelbsp/
+/buildifier

Jenkinsfile

@@ -221,12 +221,20 @@ def bazelTest = {
             stage('bazelisk test ...') {
                 withCredentials([string(credentialsId: 'bazel-auth-token-b64', variable: 'BAZEL_AUTH_TOKEN_B64')]) {
                     timeout(time: 120, unit: 'MINUTES') {
-                        def cmd = 'bazelisk test --config=ci --show_timestamps --test_output=errors --curses=no --force_pic --remote_header="Authorization=Basic $BAZEL_AUTH_TOKEN_B64"'
+                        def cmd = 'bazelisk test --config=ci --show_timestamps --test_output=errors --curses=no --force_pic --remote_header="Authorization=Basic $BAZEL_AUTH_TOKEN_B64" --profile=build.profile'
                         try {
-                            sh label: 'Bazel Build', script: cmd + ' ...';
+                            try {
+                                sh label: 'Test, using cached results and building a minimum of dependencies', script: cmd + ' ...';
+                            } finally {
+                                sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                            }
                         } catch (e) {
                             currentBuild.result = 'FAILURE';
-                            sh label: 'Bazel Build (keep_going)', script: cmd + ' --keep_going ...';
+                            try {
+                                sh label: 'Test (keep_going)', script: cmd + ' --keep_going ...';
+                            } finally {
+                                sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                            }
                         }
                     }
                 }

README.md

@@ -329,7 +329,7 @@ save_flow_metrics_limits <TEST_NAME>
 
 ``` text
 openroad [-help] [-version] [-no_init] [-exit] [-gui]
-         [-threads count|max] [-log file_name] cmd_file
+         [-threads count|max] [-log file_name] [-db file_name] cmd_file
   -help              show help and exit
   -version           show version and exit
   -no_init           do not read .openroad init file
@@ -339,6 +339,7 @@ openroad [-help] [-version] [-no_init] [-exit] [-gui]
   -gui               start in gui mode
   -python            start with python interpreter [limited to db operations]
   -log <file_name>   write a log in <file_name>
+  -db <file_name>    open a .odb database at startup
   cmd_file           source cmd_file
 ```
 

bazel/BUILD

@@ -1,6 +1,8 @@
 load("@openroad_rules_python//python:pip.bzl", "compile_pip_requirements")
 load("@rules_cc//cc:cc_library.bzl", "cc_library")
 
+package(features = ["layering_check"])
+
 compile_pip_requirements(
     name = "requirements",
     src = "requirements.in",

bazel/openmp/BUILD

@@ -14,6 +14,7 @@
 
 package(
     default_visibility = ["//visibility:private"],
+    features = ["layering_check"],
 )
 
 exports_files(

docs/user/Bazel.md

@@ -359,3 +359,13 @@ This will:
 - launch the GUI opening gui_final gcd
 
 `bazelisk run test/orfs/gcd:gcd_final` run alone would create the `/tmp/gcd` folder and the arguments. The arguments after `--` are forwarded to the `/tmp/gcd/make` script that invokes make with the gcd ORFS project set up in `/tmp/gcd/_main/config.mk`.
+
+## Hacking ORFS with `//test/orfs/gcd:gcd_test` test case
+
+First create a local work folder with all dependencies for the step that you want to work on:
+
+    bazelisk run //test/orfs/gcd:gcd_floorplan_deps /tmp/floorplan
+
+Now run make directly with the `/tmp/floorplan/_main` work folder, but be sure to use the `do-` targets that side-step ORFS make dependency checking:
+
+    make --file ~/OpenROAD-flow-scripts/flow/Makefile --dir /tmp/floorplan/_main DESIGN_CONFIG=config.mk do-floorplan

etc/BUILD

@@ -1,5 +1,7 @@
 load("@openroad_rules_python//python:defs.bzl", "py_binary")
 
+package(features = ["layering_check"])
+
 py_binary(
     name = "file_to_string",
     srcs = [

openroad/BUILD

@@ -4,6 +4,8 @@ load("@openroad_rules_python//python:defs.bzl", "py_library")
 # Copyright (c) 2025-2025, The OpenROAD Authors
 load("@openroad_rules_python//python:packaging.bzl", "py_package", "py_wheel")
 
+package(features = ["layering_check"])
+
 py_library(
     name = "openroadpy",
     srcs = [

src/Main.cc

@@ -88,6 +88,7 @@ int cmd_argc;
 char** cmd_argv;
 static const char* log_filename = nullptr;
 static const char* metrics_filename = nullptr;
+static const char* read_odb_filename = nullptr;
 static bool no_settings = false;
 static bool minimize = false;
 
@@ -243,6 +244,7 @@ int main(int argc, char* argv[])
     std::filesystem::remove(metrics_filename, err_ignored);
   }
 
+  read_odb_filename = findCmdLineKey(argc, argv, "-db");
   no_settings = findCmdLineFlag(argc, argv, "-no_settings");
   minimize = findCmdLineFlag(argc, argv, "-minimize");
 
@@ -449,6 +451,21 @@ static int tclAppInit(int& argc,
 
     const bool gui_enabled = gui::Gui::enabled();
 
+    if (read_odb_filename) {
+      std::string cmd = fmt::format("read_db {{{}}}", read_odb_filename);
+      if (!gui_enabled) {
+        if (Tcl_Eval(interp, cmd.c_str()) != TCL_OK) {
+          fprintf(stderr,
+                  "Error: failed to read_db %s: %s\n",
+                  read_odb_filename,
+                  Tcl_GetStringResult(interp));
+          exit(1);
+        }
+      } else {
+        gui::Gui::get()->addRestoreStateCommand(cmd);
+      }
+    }
+
     const char* home = getenv("HOME");
     if (!findCmdLineFlag(argc, argv, "-no_init") && home) {
       const char* restore_state_cmd = "include -echo -verbose {{{}}}";
@@ -525,7 +542,7 @@ static void showUsage(const char* prog, const char* init_filename)
 {
   printf("Usage: %s [-help] [-version] [-no_init] [-no_splash] [-exit] ", prog);
   printf("[-gui] [-threads count|max] [-log file_name] [-metrics file_name] ");
-  printf("[-no_settings] [-minimize] cmd_file\n");
+  printf("[-db file_name] [-no_settings] [-minimize] cmd_file\n");
   printf("  -help                 show help and exit\n");
   printf("  -version              show version and exit\n");
   printf("  -no_init              do not read %s init file\n", init_filename);
@@ -543,6 +560,7 @@ static void showUsage(const char* prog, const char* init_filename)
   printf("  -log <file_name>      write a log in <file_name>\n");
   printf(
       "  -metrics <file_name>  write metrics in <file_name> in JSON format\n");
+  printf("  -db <file_name>      open a .odb database at startup\n");
   printf("  cmd_file              source cmd_file\n");
 }
 

src/ant/test/BUILD

@@ -1,5 +1,7 @@
 load("//test:regression.bzl", "regression_test")
 
+package(features = ["layering_check"])
+
 # From CMakeLists.txt or_integration_tests(TESTS
 COMPULSORY_TESTS = [
     "ant_check",