Merge remote-tracking branch 'origin/master' into gui-chiplets3

Author: maliberty

.github/dependabot.yml

@@ -4,7 +4,3 @@ updates:
     directory: "/"
     schedule:
       interval: "daily"
-  - package-ecosystem: "gitsubmodule"
-    directory: "/"
-    schedule:
-      interval: "daily"

.github/workflows/github-actions-clang-tidy.yml

@@ -17,7 +17,7 @@ jobs:
         uses: The-OpenROAD-Project/clang-tidy-review@master
         id: review
         with:
-          clang_tidy_version: 15
+          clang_tidy_version: 19
           build_dir: "./build"
           cmake_command: cmake . -B build
           config_file: ".clang-tidy"

.gitignore

@@ -57,10 +57,7 @@ obj-x86_64-linux-gnu/
 
 user.bazelrc
 
-bazel-bin
-bazel-out
-bazel-testlogs
-bazel-OpenROAD
+bazel-*
 
 projectview.bazelproject
 .bsp/

Jenkinsfile

@@ -1,5 +1,9 @@
 @Library('utils@or-v2.0.1') _
 
+def logHostname() {
+    sh label: "Running on ${env.NODE_NAME}", script: "echo 'Node context established.'"
+}
+
 def baseTests(String image) {
     Map base_tests = [failFast: false];
 
@@ -43,6 +47,7 @@ def baseTests(String image) {
     flow_tests.each { current_test ->
         base_tests["Flow Test - ${current_test}"] = {
             node {
+                logHostname()
                 withDockerContainer(args: '-u root', image: image) {
                     stage("Setup ${current_test}") {
                         sh label: 'Configure git', script: "git config --system --add safe.directory '*'";
@@ -78,6 +83,7 @@ def getParallelTests(String image) {
     def ret = [
         'Docs Tester': {
             node {
+                logHostname()
                 withDockerContainer(args: '-u root', image: image) {
                     stage('Setup Docs Test') {
                         echo "Setting up Docs Tester environment in ${image}";
@@ -101,6 +107,7 @@ def getParallelTests(String image) {
 
         'Build without GUI': {
             node {
+                logHostname()
                 withDockerContainer(args: '-u root', image: image) {
                     stage('Setup no-GUI Build') {
                         echo "Build without GUI";
@@ -118,6 +125,7 @@ def getParallelTests(String image) {
 
         'Build without Test': {
             node {
+                logHostname()
                 withDockerContainer(args: '-u root', image: image) {
                     stage('Setup no-test Build') {
                         echo "Build without Tests";
@@ -139,6 +147,7 @@ def getParallelTests(String image) {
 
         'Build on RHEL8': {
             node ('rhel8') {
+                logHostname()
                 stage('Setup RHEL8 Build') {
                     checkout scm;
                 }
@@ -172,6 +181,7 @@ def getParallelTests(String image) {
 
         'Unit Tests Ninja': {
             node {
+                logHostname()
                 withDockerContainer(args: '-u root', image: image) {
                     stage('Setup Ninja Tests') {
                         sh label: 'Configure git', script: "git config --system --add safe.directory '*'";
@@ -195,6 +205,7 @@ def getParallelTests(String image) {
 
         'Compile with C++20': {
             node {
+                logHostname()
                 withDockerContainer(args: '-u root', image: image) {
                     stage('Setup C++20 Compile') {
                         sh label: 'Configure git', script: "git config --system --add safe.directory '*'";
@@ -213,32 +224,38 @@ def getParallelTests(String image) {
 
 def bazelTest = {
     node {
+        logHostname()
         stage('Setup') {
             checkout scm;
             sh label: 'Setup Docker Image', script: 'docker build -f docker/Dockerfile.bazel -t openroad/bazel-ci .';
         }
-        withDockerContainer(args: '-u root -v /var/run/docker.sock:/var/run/docker.sock', image: 'openroad/bazel-ci:latest') {
-            stage('bazelisk test ...') {
-                withCredentials([string(credentialsId: 'bazel-auth-token-b64', variable: 'BAZEL_AUTH_TOKEN_B64')]) {
-                    timeout(time: 120, unit: 'MINUTES') {
-                        def cmd = 'bazelisk test --config=ci --show_timestamps --test_output=errors --curses=no --force_pic --remote_header="Authorization=Basic $BAZEL_AUTH_TOKEN_B64" --profile=build.profile'
-                        try {
-                            try {
-                                sh label: 'Test, using cached results and building a minimum of dependencies', script: cmd + ' ...';
-                            } finally {
-                                sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
-                            }
-                        } catch (e) {
-                            currentBuild.result = 'FAILURE';
+        try {
+            withDockerContainer(args: '-u root -v /var/run/docker.sock:/var/run/docker.sock', image: 'openroad/bazel-ci:latest') {
+                stage('bazelisk test ...') {
+                    withCredentials([string(credentialsId: 'bazel-auth-token-b64', variable: 'BAZEL_AUTH_TOKEN_B64')]) {
+                        timeout(time: 120, unit: 'MINUTES') {
+                            def cmd = 'bazelisk test --config=ci --show_timestamps --test_output=errors --curses=no --force_pic --remote_header="Authorization=Basic $BAZEL_AUTH_TOKEN_B64" --profile=build.profile'
                             try {
-                                sh label: 'Test (keep_going)', script: cmd + ' --keep_going ...';
-                            } finally {
-                                sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                                try {
+                                    sh label: 'Test, using cached results and building a minimum of dependencies', script: cmd + ' ...';
+                                } finally {
+                                    sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                                }
+                            } catch (e) {
+                                try {
+                                    sh label: 'Test (keep_going)', script: cmd + ' --keep_going ...';
+                                } catch (e2) {
+                                    currentBuild.result = 'FAILURE';
+                                } finally {
+                                    sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                                }
                             }
                         }
                     }
                 }
             }
+        } catch (IOException e) {
+            echo "Caught: ${e}";
         }
     }
 }
@@ -260,6 +277,7 @@ def dockerTests = {
         test_os.each { os ->
             build_docker_images["Test Installer - ${os.name}"] = {
                 node {
+                    logHostname()
                     checkout scm;
                     sh label: 'Build Docker image', script: "./etc/DockerHelper.sh create -target=builder -os=${os.image}";
                     sh label: 'Test Docker image', script: "./etc/DockerHelper.sh test -target=builder -os=${os.image} -smoke";

MODULE.bazel

@@ -109,7 +109,7 @@ bazel_dep(name = "googletest", version = "1.17.0", dev_dependency = True)
 # BCR, they should depend on their own version.
 bazel_dep(name = "glpk", version = "5.0.bcr.3", repo_name = "org_gnu_glpk")
 
-## Fix the compiler version and avoid any local compiler
+## Lock the compiler version and avoid any local compiler
 bazel_dep(name = "toolchains_llvm", version = "1.5.0")
 
 # Configure and register the toolchain.
@@ -153,7 +153,7 @@ bazel_dep(name = "bazel-orfs")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 git_override(
     module_name = "bazel-orfs",
-    commit = "2aa6a9dd3c0006c5358e363fcac9e209c4dccc47",
+    commit = "677ecf4bb7195903bb58beae171d254dac984e27",
     remote = "https://github.com/The-OpenROAD-Project/bazel-orfs.git",
 )
 
@@ -162,10 +162,10 @@ orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 orfs.default(
     # Official image https://hub.docker.com/r/openroad/orfs/tags
-    image = "docker.io/openroad/orfs:v3.0-3911-g99312fa58",
+    image = "docker.io/openroad/orfs:v3.0-4072-g2a1832971",
     # Use OpenROAD of this repo instead of from the docker image
     openroad = "//:openroad",
-    sha256 = "36d3ac23732803c9e47181e167a105c69d4d6927a96782c4a4a27ceca40d8ff8",
+    sha256 = "d5ac8b165ebab339eb98beb63a463eab5ed78364335fb1455c2e1d75eb757c3d",
 )
 use_repo(orfs, "com_github_nixos_patchelf_download")
 use_repo(orfs, "docker_orfs")
@@ -195,9 +195,9 @@ maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
 maven.install(
     name = "maven",
     artifacts = [
-        "org.chipsalliance:chisel_2.13:7.0.0",
-        "org.chipsalliance:chisel-plugin_2.13.16:7.0.0",
     ],
+    # Update by running: bazelisk run @maven//:pin
+    lock_file = "//bazel:maven_install.json",
     repositories = [
         "https://repo1.maven.org/maven2",
         "https://s01.oss.sonatype.org/content/repositories/releases",