fix & test

Fixing some additional issues with Rigidbody testing and assuring we are comparing the correct position and rotation. With NetworkTransformOwnershipTests, it turned out that the movement of the non-kinematic body was giving the Rigidbody a linear velocity under certain conditions.

Removing the warning about resetting dirty when not initialized during NetworkVariableTests (removing a couple thousand log messages).

Since the service is now consuming the initial synchronize event, updated how in-scene objects are spawned initially.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Components/Messages/NetworkTransformMessage.cs

@@ -199,7 +199,7 @@ public void Handle(ref NetworkContext context)
                 Debug.LogError($"[{nameof(NetworkTransformMessage)}][Dropped] Reciever {nameof(NetworkTransform)} was not set!");
                 return;
             }
-            m_ReceiverNetworkTransform.TransformStateUpdate(ref State);
+            m_ReceiverNetworkTransform.TransformStateUpdate(ref State, context.SenderId);
         }
     }
 }

com.unity.netcode.gameobjects/Components/NetworkTransform.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Runtime.CompilerServices;
+using System.Text;
 using Unity.Mathematics;
 using Unity.Netcode.Transports.UTP;
 using UnityEngine;
@@ -2071,12 +2072,19 @@ private void OnNetworkTick()
             // As long as we are still authority
             if (CanCommitToTransform)
             {
+                if (m_CachedNetworkManager.DistributedAuthorityMode && !IsOwner)
+                {
+                    Debug.LogError($"Non-owner Client-{m_CachedNetworkManager.LocalClientId} is being updated by network tick still!!!!");
+                }
                 // Update any changes to the transform
                 var transformSource = transform;
                 OnUpdateAuthoritativeState(ref transformSource);
-
+#if COM_UNITY_MODULES_PHYSICS
+                m_CurrentPosition = m_TargetPosition = m_UseRigidbodyForMotion ? m_NetworkRigidbodyInternal.GetPosition() : GetSpaceRelativePosition();
+#else
                 m_CurrentPosition = GetSpaceRelativePosition();
                 m_TargetPosition = GetSpaceRelativePosition();
+#endif
             }
             else // If we are no longer authority, unsubscribe to the tick event
             if (NetworkManager != null && NetworkManager.NetworkTickSystem != null)
@@ -2104,6 +2112,8 @@ internal void UpdatePositionInterpolator(Vector3 position, double time, bool res
             }
         }
 
+        internal bool LogMotion;
+
         /// <summary>
         /// Applies the authoritative state to the transform
         /// </summary>
@@ -2245,6 +2255,11 @@ private void ApplyAuthoritativeState()
                 if (m_UseRigidbodyForMotion)
                 {
                     m_NetworkRigidbodyInternal.MovePosition(m_CurrentPosition);
+                    if (LogMotion)
+                    {
+                        Debug.Log($"[Client-{m_CachedNetworkManager.LocalClientId}][Interpolate: {networkState.UseInterpolation}][TransPos: {transform.position}][RBPos: {m_NetworkRigidbodyInternal.GetPosition()}][CurrentPos: {m_CurrentPosition}");
+                    }
+
                 }
                 else
 #endif
@@ -2676,7 +2691,7 @@ protected virtual void OnNetworkTransformStateUpdated(ref NetworkTransformState
 
         }
 
-
+        internal bool LogStateUpdate;
         /// <summary>
         /// Only non-authoritative instances should invoke this method
         /// </summary>
@@ -2698,6 +2713,24 @@ private void OnNetworkStateChanged(NetworkTransformState oldState, NetworkTransf
             // Get the time when this new state was sent
             newState.SentTime = new NetworkTime(m_CachedNetworkManager.NetworkConfig.TickRate, newState.NetworkTick).Time;
 
+            if (LogStateUpdate)
+            {
+                var builder = new StringBuilder();
+                builder.AppendLine($"[Client-{m_CachedNetworkManager.LocalClientId}][State Update: {newState.GetNetworkTick()}][HasPos: {newState.HasPositionChange}][Has Rot: {newState.HasRotAngleChange}][Has Scale: {newState.HasScaleChange}]");
+                if (newState.HasPositionChange)
+                {
+                    builder.AppendLine($"Position = {newState.GetPosition()}");
+                }
+                if (newState.HasRotAngleChange)
+                {
+                    builder.AppendLine($"Rotation = {newState.GetRotation()}");
+                }
+                if (newState.HasScaleChange)
+                {
+                    builder.AppendLine($"Scale = {newState.GetScale()}");
+                }
+                Debug.Log(builder);
+            }
             // Apply the new state
             ApplyUpdatedState(newState);
 
@@ -3324,8 +3357,12 @@ public bool IsServerAuthoritative()
         /// Invoked by <see cref="NetworkTransformMessage"/> to update the transform state
         /// </summary>
         /// <param name="networkTransformState"></param>
-        internal void TransformStateUpdate(ref NetworkTransformState networkTransformState)
+        internal void TransformStateUpdate(ref NetworkTransformState networkTransformState, ulong senderId)
         {
+            if (CanCommitToTransform)
+            {
+                Debug.LogError($"Authority receiving transform update from Client-{senderId}!");
+            }
             // Store the previous/old state
             m_OldState = m_LocalAuthoritativeNetworkState;
 
@@ -3364,7 +3401,7 @@ private void UpdateTransformState()
                 State = m_LocalAuthoritativeNetworkState,
                 DistributedAuthorityMode = m_CachedNetworkManager.DistributedAuthorityMode,
                 // Don't populate if we are the DAHost as we send directly to each client
-                TargetIds = m_CachedNetworkManager.DistributedAuthorityMode && !m_CachedNetworkManager.DAHost ? NetworkObject.Observers.ToArray() : null,
+                TargetIds = m_CachedNetworkManager.DistributedAuthorityMode && !m_CachedNetworkManager.DAHost ? NetworkObject.Observers.Where((c) => c != m_CachedNetworkManager.LocalClientId).ToArray() : null,
             };
 
 

com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs

@@ -1321,17 +1321,8 @@ internal void ServerSpawnSceneObjectsOnStartSweep()
                         {
                             ownerId = NetworkManager.LocalClientId;
                         }
-                        // DANGO-EXP TODO: Once the service consumes the initial SceneEventType.Synchronize sent to it,
-                        // we should remove this.
-                        if (isConnectedCMBService)
-                        {
-                            networkObjects[i].IsSceneObject = true;
-                            networkObjects[i].Spawn(true);
-                        }
-                        else
-                        {
-                            SpawnNetworkObjectLocally(networkObjects[i], GetNetworkObjectId(), true, false, ownerId, true);
-                        }
+
+                        SpawnNetworkObjectLocally(networkObjects[i], GetNetworkObjectId(), true, false, ownerId, true);
                     }
                 }
             }