`GetNetworkBehaviourAtOrderIndex` is now internal in 2.x

[PitouGames]

Description

The function GetNetworkBehaviourAtOrderIndex was public in NGO 1.x:

com.unity.netcode.gameobjects/com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

Line 1611 in 7a81722

public NetworkBehaviour GetNetworkBehaviourAtOrderIndex(ushort index)

In 2.x, the same function is now internal:

com.unity.netcode.gameobjects/com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

Line 2765 in 098e68e

internal NetworkBehaviour GetNetworkBehaviourAtOrderIndex(ushort index)

I am using this function in my project for a custom generic NetworkBehaviourReference. My script is very similar to the one proposed in #2837.

Now the function is restricted, it prevent me to update to NGO 2.x.

• The commit that made it private is e36996c#diff-d4983ac59796152466f8c034e7251a80a34265d80fda82cc7ee109ac7774229bR2541 and don't document why it's now private.
• The changelog don't mention this breaking change.
• The inverse function GetNetworkBehaviourOrderIndex is public:

  com.unity.netcode.gameobjects/com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

  Line 2738 in 098e68e

  public ushort GetNetworkBehaviourOrderIndex(NetworkBehaviour instance)

It is unclear why GetNetworkBehaviourAtOrderIndex has been made internal? Was it intentionnal?

I'm requesting this function to be made public again (see #2678 for the 1.x request). Since it's just a getter, I don't see anything preventing us to access it.

[NoelStephensNILC]

Hi @PitouGames
I am out of office currently but will make sure that this issue is resolved in the next update.
Apologies for this inconvenience as it was my fault for making that update.

[NoelStephensUnity]

@PitouGames
While I resolve this issue, you can work around this by obtaining NetworkBehaviours using:

NetworkBehaviour.GetNetworkBehaviour

You have to invoke this from a derived NetworkBehaviour on the relative/target NetworkObject.

[NoelStephensUnity]

#3541 will resolve this issue and will be in the next v2.x update.