From 910d6a104bfa5eb53b519deeaeedef37aacb2018 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Norbert=20Ill=C3=A9s?= Date: Mon, 7 Apr 2025 17:27:06 +0200 Subject: [PATCH 1/2] fix: memory leak without domain reload playModeStateChanged never gets unsubscribed --- com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs b/com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs index 2009de87bc..71ecce9498 100644 --- a/com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs +++ b/com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs @@ -1629,6 +1629,10 @@ private void OnDestroy() { Singleton = null; } + +#if UNITY_EDITOR + EditorApplication.playModeStateChanged -= ModeChanged; +#endif } // Command line options From 379c4a194097188ed2cd90171576186b01102bde Mon Sep 17 00:00:00 2001 From: Noel Stephens Date: Fri, 25 Apr 2025 10:54:52 -0500 Subject: [PATCH 2/2] Update CHANGELOG.md --- com.unity.netcode.gameobjects/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.netcode.gameobjects/CHANGELOG.md b/com.unity.netcode.gameobjects/CHANGELOG.md index 85ad8ff0f6..b817a0b6ea 100644 --- a/com.unity.netcode.gameobjects/CHANGELOG.md +++ b/com.unity.netcode.gameobjects/CHANGELOG.md @@ -13,6 +13,7 @@ Additional documentation and release notes are available at [Multiplayer Documen ### Fixed +- Fixed memory leaks when domain reload is disabled. (#3427) - Fixed an exception being thrown when unregistering a custom message handler from within the registered callback. (#3417) ### Changed