From 3a6514975526c357570288b86bd2a30103e353ae Mon Sep 17 00:00:00 2001 From: michalChrobot Date: Mon, 28 Apr 2025 09:43:02 +0200 Subject: [PATCH 1/5] Changed standalone tests trigger on PRs to use only Ubuntu --- .yamato/_triggers.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.yamato/_triggers.yml b/.yamato/_triggers.yml index 3018bc5176..fc4f3c712d 100644 --- a/.yamato/_triggers.yml +++ b/.yamato/_triggers.yml @@ -46,6 +46,8 @@ pull_request_trigger: name: Pull Request Trigger (develop, develop-2.0.0, & release branches) dependencies: + # Run project standards to verify package/default project + - .yamato/project-standards.yml#standards_ubuntu_testproject_6000.0 # Run package EditMode and Playmode package tests on trunk - .yamato/_run-all.yml#run_all_package_tests_trunk # Run package EditMode and Playmode package tests on minimum supported editor (6000.0 in case of NGOv2.X) @@ -54,9 +56,9 @@ pull_request_trigger: - .yamato/_run-all.yml#run_all_project_tests_trunk # Run project EditMode and PLaymode project tests on minimum supported editor (6000.0 in case of NGOv2.X) - .yamato/_run-all.yml#run_all_project_tests_6000 - # Run standalone test with mixture of parameters to make sure there are no obvious issues with most common platform (for example --fail-on-assert option is not present with package/project tests). We run 2 different combinations with different platform/editor/scripting backend. - - .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_mac_il2cpp_trunk - - .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_win_mono_6000.0 + # Run standalone test. We run it only on Ubuntu since it's the fastest machine, and it was noted that for example distribution on macOS is taking 40m since we switched to Apple Silicon + # Coverage on other standalone machines is present in Nightly job so it's enough to not run all of them for PRs + - .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_ubuntu_il2cpp_trunk triggers: cancel_old_ci: true pull_requests: From cdf6b00b09bc70e05842d911bf76f079d5ca4f43 Mon Sep 17 00:00:00 2001 From: michalChrobot Date: Mon, 28 Apr 2025 09:48:37 +0200 Subject: [PATCH 2/5] corrected editor to oldest supported --- .yamato/_triggers.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.yamato/_triggers.yml b/.yamato/_triggers.yml index fc4f3c712d..6d60b4687b 100644 --- a/.yamato/_triggers.yml +++ b/.yamato/_triggers.yml @@ -58,7 +58,7 @@ pull_request_trigger: - .yamato/_run-all.yml#run_all_project_tests_6000 # Run standalone test. We run it only on Ubuntu since it's the fastest machine, and it was noted that for example distribution on macOS is taking 40m since we switched to Apple Silicon # Coverage on other standalone machines is present in Nightly job so it's enough to not run all of them for PRs - - .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_ubuntu_il2cpp_trunk + - .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_ubuntu_il2cpp_6000.0 triggers: cancel_old_ci: true pull_requests: From 9a2d227585e51cfa0c08d6fb6e818ba1056a5306 Mon Sep 17 00:00:00 2001 From: michalChrobot Date: Mon, 28 Apr 2025 09:53:47 +0200 Subject: [PATCH 3/5] Corrected standards dependency --- .yamato/_triggers.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.yamato/_triggers.yml b/.yamato/_triggers.yml index 6d60b4687b..b3cf8d54cb 100644 --- a/.yamato/_triggers.yml +++ b/.yamato/_triggers.yml @@ -47,7 +47,7 @@ pull_request_trigger: name: Pull Request Trigger (develop, develop-2.0.0, & release branches) dependencies: # Run project standards to verify package/default project - - .yamato/project-standards.yml#standards_ubuntu_testproject_6000.0 + - .yamato/project-standards.yml#standards_ubuntu_testproject_trunk # Run package EditMode and Playmode package tests on trunk - .yamato/_run-all.yml#run_all_package_tests_trunk # Run package EditMode and Playmode package tests on minimum supported editor (6000.0 in case of NGOv2.X) @@ -83,7 +83,6 @@ develop_nightly: dependencies: # Run project standards to verify package/default project - .yamato/project-standards.yml#standards_ubuntu_testproject_trunk - - .yamato/project-standards.yml#standards_ubuntu_testproject_6000.0 # Run APV jobs to make sure the change won't break any dependants - .yamato/wrench/preview-a-p-v.yml#all_preview_apv_jobs # Run package EditMode and Playmode tests on desktop platforms on trunk and 6000.0 From 17a51bdf10c3954a87b6ba866d27f1e56c02e50b Mon Sep 17 00:00:00 2001 From: michalChrobot Date: Mon, 28 Apr 2025 09:55:45 +0200 Subject: [PATCH 4/5] Removed standards check since it's present in Initial checks --- .yamato/_triggers.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.yamato/_triggers.yml b/.yamato/_triggers.yml index b3cf8d54cb..cbbbaf48aa 100644 --- a/.yamato/_triggers.yml +++ b/.yamato/_triggers.yml @@ -42,12 +42,10 @@ # In order to have better coverage we run desktop standalone tests with different configurations which allows to mostly cover for different platforms, scripting backends and editor versions. # This job will FIRST run "run_quick_checks" jobs (defined in _run-all.yml) since it's the dependency of project pack jobs which is on the lowest dependency tier. This runs the fastest checks (like PVP or code standards) and ONLY IF those pass it will run the rest of the tests. # This optimization allows to speed up feedback look for any "obvious" errors and save resources. -# Since standards job is a part of initial checks it's not present as direct dependency here +# Since standards job is a part of initial checks it's not present as direct dependency here!!!!!!!!!!!!!!!!!!!! pull_request_trigger: name: Pull Request Trigger (develop, develop-2.0.0, & release branches) dependencies: - # Run project standards to verify package/default project - - .yamato/project-standards.yml#standards_ubuntu_testproject_trunk # Run package EditMode and Playmode package tests on trunk - .yamato/_run-all.yml#run_all_package_tests_trunk # Run package EditMode and Playmode package tests on minimum supported editor (6000.0 in case of NGOv2.X) From c9dc1d7853c314ce78b1aececcd777262633ea65 Mon Sep 17 00:00:00 2001 From: michalChrobot Date: Mon, 28 Apr 2025 09:58:50 +0200 Subject: [PATCH 5/5] Corrected webgl job constructiuon --- .yamato/_run-all.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.yamato/_run-all.yml b/.yamato/_run-all.yml index 1fb8cdec3f..b495e3a42b 100644 --- a/.yamato/_run-all.yml +++ b/.yamato/_run-all.yml @@ -138,12 +138,12 @@ run_all_webgl_builds_6000: name: Run All WebGl Build [6000.0] dependencies: {% for project in projects.default -%} -{% if platform.name != "mac" -%} # There is an error about "Light baking could not be started because no valid OpenCL device could be found". Tracked in MTT-11726 {% for platform in test_platforms.desktop -%} +{% if platform.name != "mac" -%} # There is an error about "Light baking could not be started because no valid OpenCL device could be found". Tracked in MTT-11726 - .yamato/webgl-build.yml#webgl_build_{{ project.name }}_{{ platform.name }}_6000.0 -{% endfor -%} {% endif -%} {% endfor -%} +{% endfor -%} # Runs all Desktop tests