From c25c79d3cd1403cf9c0e7cc4420c321fb70ef981 Mon Sep 17 00:00:00 2001 From: NoelStephensUnity Date: Thu, 5 Jun 2025 12:52:39 -0500 Subject: [PATCH 1/2] fix This resolves an issue where a very small memory leak could occur within the ConnectionApprovedMessage. --- .../Runtime/Messaging/Messages/ConnectionApprovedMessage.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/com.unity.netcode.gameobjects/Runtime/Messaging/Messages/ConnectionApprovedMessage.cs b/com.unity.netcode.gameobjects/Runtime/Messaging/Messages/ConnectionApprovedMessage.cs index 02c63bfd34..a89478be0a 100644 --- a/com.unity.netcode.gameobjects/Runtime/Messaging/Messages/ConnectionApprovedMessage.cs +++ b/com.unity.netcode.gameobjects/Runtime/Messaging/Messages/ConnectionApprovedMessage.cs @@ -262,6 +262,7 @@ public void Handle(ref NetworkContext context) { NetworkLog.LogWarning($"[Client-{OwnerClientId}] Receiving duplicate connection approved. Client is already connected!"); } + ConnectedClientIds.Dispose(); return; } @@ -304,6 +305,9 @@ public void Handle(ref NetworkContext context) } } + // Dispose after it has been used. + ConnectedClientIds.Dispose(); + // Only if scene management is disabled do we handle NetworkObject synchronization at this point if (!networkManager.NetworkConfig.EnableSceneManagement) { @@ -387,7 +391,6 @@ public void Handle(ref NetworkContext context) } } } - ConnectedClientIds.Dispose(); } } } From da745cf85803eeb4f94b6e96629f92df668bc733 Mon Sep 17 00:00:00 2001 From: NoelStephensUnity Date: Thu, 5 Jun 2025 12:56:28 -0500 Subject: [PATCH 2/2] update adding changelog entry --- com.unity.netcode.gameobjects/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/com.unity.netcode.gameobjects/CHANGELOG.md b/com.unity.netcode.gameobjects/CHANGELOG.md index 4f56610a46..581b9414c5 100644 --- a/com.unity.netcode.gameobjects/CHANGELOG.md +++ b/com.unity.netcode.gameobjects/CHANGELOG.md @@ -12,6 +12,8 @@ Additional documentation and release notes are available at [Multiplayer Documen ### Fixed +- Fixed: Issue where there was a potential for a small memory leak in the `ConnectionApprovedMessage`. (#3486) + ### Changed ## [2.4.0] - 2025-06-02