Skip to content

Commit 58c4a19

Browse files
committed
Fix for --latest=true flag for releases
Previously, --latest=true was not always marking a release as latest due to the prerelease default on a public repo. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
1 parent 8c13bff commit 58c4a19

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

cmd/release.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,19 @@ When a version is given explicitly, --major/--minor/--patch are ignored.`,
137137
latest = latestStr == "true"
138138
}
139139

140+
// If user explicitly set --latest=true but did not set --prerelease,
141+
// disable prerelease so that --latest takes effect (gh CLI ignores
142+
// --latest when --prerelease is also passed).
143+
if latestStr == "true" && prereleaseStr == "" {
144+
prerelease = false
145+
}
146+
147+
// Likewise, if user explicitly set --prerelease=true but did not
148+
// set --latest, disable latest so the flags stay consistent.
149+
if prereleaseStr == "true" && latestStr == "" {
150+
latest = false
151+
}
152+
140153
if private {
141154
fmt.Println("Private repo detected.")
142155
} else {

0 commit comments

Comments
 (0)