fix: fix falling back to latest for apt

Author: aminya

dist/legacy/setup-cpp.js

@@ -1,6 +1,6 @@
 {
   "name": "setup-apt",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Setup apt packages and repositories in Debian/Ubuntu-based distributions",
   "repository": "https://github.com/aminya/setup-cpp",
   "homepage": "https://github.com/aminya/setup-cpp/tree/master/packages/setup-apt",

dist/legacy/setup-cpp.js.map

@@ -1,4 +1,3 @@
-import { warning } from "ci-log"
 import escapeRegex from "escape-string-regexp"
 import { execa } from "execa"
 import { getAptEnv } from "./apt-env.js"
@@ -37,7 +36,12 @@ export async function qualifiedNeededAptPackage(pack: AptPackage, apt: string =
   return (await isAptPackInstalled(qualified)) ? undefined : qualified
 }
 
-async function aptPackageType(apt: string, name: string, version: string | undefined): Promise<AptPackageType> {
+async function aptPackageType(
+  apt: string,
+  name: string,
+  version: string | undefined,
+  fallBackToLatest: boolean,
+): Promise<AptPackageType> {
   if (version !== undefined && version !== "") {
     const { stdout } = await execa("apt-cache", [
       "search",
@@ -72,10 +76,10 @@ async function aptPackageType(apt: string, name: string, version: string | undef
   // If apt-cache fails, update the repos and try again
   if (!updatedRepos) {
     updateAptReposMemoized(apt)
-    return aptPackageType(apt, name, version)
+    return aptPackageType(apt, name, version, fallBackToLatest)
   }
 
-  if (version === undefined || version === "") {
+  if (version === undefined || version === "" || fallBackToLatest) {
     // if the version is undefined or empty, return the name as a package name
     return AptPackageType.Name
   }
@@ -86,21 +90,14 @@ async function aptPackageType(apt: string, name: string, version: string | undef
 async function getAptArg(apt: string, pack: AptPackage) {
   const { name, version, fallBackToLatest = false } = pack
 
-  const package_type = await aptPackageType(apt, name, version)
+  const package_type = await aptPackageType(apt, name, version, fallBackToLatest)
   switch (package_type) {
     case AptPackageType.NameDashVersion:
       return `${name}-${version}`
     case AptPackageType.NameEqualsVersion:
       return `${name}=${version}`
     case AptPackageType.Name: {
-      if (version === undefined || version === "") {
-        return name
-      }
-      if (fallBackToLatest) {
-        warning(`Could not find package '${name}' with version '${version}'. Installing the latest version.`)
-        return name
-      }
-      throw new Error(`Could not find package '${name}' with version '${version}'`)
+      return name
     }
     default:
       throw new Error(`Could not find package '${name}' ${version ?? "with unspecified version"}`)