Skip to content

Commit f850231

Browse files
committed
Fix implicit nullable parameters
1 parent a79dc87 commit f850231

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/Internal/Posix/PosixRunner.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ final class PosixRunner implements ProcessRunner
3838
public function start(
3939
string $command,
4040
Cancellation $cancellation,
41-
string $workingDirectory = null,
41+
?string $workingDirectory = null,
4242
array $environment = [],
4343
array $options = [],
4444
): ProcessContext {

src/Internal/ProcessRunner.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ interface ProcessRunner
2424
public function start(
2525
string $command,
2626
Cancellation $cancellation,
27-
string $workingDirectory = null,
27+
?string $workingDirectory = null,
2828
array $environment = [],
2929
array $options = [],
3030
): ProcessContext;

src/Internal/Windows/WindowsRunner.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ final class WindowsRunner implements ProcessRunner
3131
];
3232

3333
private const WRAPPER_EXE_PATH = PHP_INT_SIZE === 8
34-
? BIN_DIR . '\\windows\\ProcessWrapper64.exe'
35-
: BIN_DIR . '\\windows\\ProcessWrapper.exe';
34+
? (BIN_DIR . '\\windows\\ProcessWrapper64.exe') : (BIN_DIR . '\\windows\\ProcessWrapper.exe');
3635

3736
private static ?string $pharWrapperPath = null;
3837

@@ -46,7 +45,7 @@ public function __construct()
4645
public function start(
4746
string $command,
4847
Cancellation $cancellation,
49-
string $workingDirectory = null,
48+
?string $workingDirectory = null,
5049
array $environment = [],
5150
array $options = []
5251
): ProcessContext {

0 commit comments

Comments
 (0)