server: fix for user account able to list child domain n/w offering

shwstppr · shwstppr · commit cb8f58b706c3 · 2019-07-12T13:39:25.000+05:30
Signed-off-by: Abhishek Kumar &lt;abhishek.mrt22@gmail.com&gt;
diff --git a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -5448,7 +5448,7 @@ public Pair<List<? extends NetworkOffering>, Integer> searchForNetworkOfferings(
                     for (String domainIdString : domainIdsArray) {
                         Long dId = Long.valueOf(domainIdString.trim());
                         if (caller.getType() != Account.ACCOUNT_TYPE_ADMIN &&
-                                !_domainDao.isChildDomain(caller.getDomainId(), dId)) {
+                                !_domainDao.isChildDomain(dId, caller.getDomainId())) {
                             toRemove = true;
                             break;
                         }

Original file line number	Diff line number	Diff line change
`@@ -5448,7 +5448,7 @@ public Pair<List<? extends NetworkOffering>, Integer> searchForNetworkOfferings(`
`5448`	`5448`	`for (String domainIdString : domainIdsArray) {`
`5449`	`5449`	`Long dId = Long.valueOf(domainIdString.trim());`
`5450`	`5450`	`if (caller.getType() != Account.ACCOUNT_TYPE_ADMIN &&`
`5451`		`- !_domainDao.isChildDomain(caller.getDomainId(), dId)) {`
	`5451`	`+ !_domainDao.isChildDomain(dId, caller.getDomainId())) {`
`5452`	`5452`	`toRemove = true;`
`5453`	`5453`	`break;`
`5454`	`5454`	`}`