Commit 0465d6e
Address Copilot review feedback on AGENTS.md
- Wrap CASE/WHEN method-chain examples in parentheses and assign to a
variable so they are valid Python as shown (Copilot #1, #2).
- Fix INTERSECT/EXCEPT mapping: the default distinct=False corresponds to
INTERSECT ALL / EXCEPT ALL, not the distinct forms. Updated both the
Set Operations section and the SQL reference table to show both the
ALL and distinct variants (Copilot #4).
- Change write_parquet / write_csv / write_json examples to file-style
paths (output.parquet, etc.) to match the convention used in existing
tests and examples. Note that a directory path is also valid for
partitioned output (Copilot #5).
Verified INTERSECT/EXCEPT semantics with a script:
df1.intersect(df2) -> [1, 1, 2] (= INTERSECT ALL)
df1.intersect(df2, distinct=True) -> [1, 2] (= INTERSECT)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent c620a80 commit 0465d6e
1 file changed
Lines changed: 18 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
| 225 | + | |
225 | 226 | | |
| 227 | + | |
226 | 228 | | |
227 | 229 | | |
228 | 230 | | |
| |||
267 | 269 | | |
268 | 270 | | |
269 | 271 | | |
270 | | - | |
271 | | - | |
272 | | - | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
273 | 275 | | |
274 | 276 | | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
275 | 280 | | |
276 | 281 | | |
277 | 282 | | |
| |||
364 | 369 | | |
365 | 370 | | |
366 | 371 | | |
367 | | - | |
| 372 | + | |
| 373 | + | |
368 | 374 | | |
369 | 375 | | |
370 | 376 | | |
| 377 | + | |
371 | 378 | | |
372 | 379 | | |
373 | | - | |
| 380 | + | |
| 381 | + | |
374 | 382 | | |
375 | 383 | | |
| 384 | + | |
376 | 385 | | |
377 | 386 | | |
378 | 387 | | |
| |||
426 | 435 | | |
427 | 436 | | |
428 | 437 | | |
429 | | - | |
430 | | - | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
431 | 442 | | |
432 | 443 | | |
433 | 444 | | |
| |||
0 commit comments