select_columns has been deprecated since DF43

Author: timsaucer

crates/core/src/dataframe.rs

@@ -468,17 +468,17 @@ impl PyDataFrame {
     fn __getitem__(&self, key: Bound<'_, PyAny>) -> PyDataFusionResult<Self> {
         if let Ok(key) = key.extract::<PyBackedStr>() {
             // df[col]
-            self.select_columns(vec![key])
+            self.select_exprs(vec![key])
         } else if let Ok(tuple) = key.cast::<PyTuple>() {
             // df[col1, col2, col3]
             let keys = tuple
                 .iter()
                 .map(|item| item.extract::<PyBackedStr>())
                 .collect::<PyResult<Vec<PyBackedStr>>>()?;
-            self.select_columns(keys)
+            self.select_exprs(keys)
         } else if let Ok(keys) = key.extract::<Vec<PyBackedStr>>() {
             // df[[col1, col2, col3]]
-            self.select_columns(keys)
+            self.select_exprs(keys)
         } else {
             let message = "DataFrame can only be indexed by string index or indices".to_string();
             Err(PyDataFusionError::Common(message))
@@ -554,13 +554,6 @@ impl PyDataFrame {
         Ok(PyTable::from(table_provider))
     }
 
-    #[pyo3(signature = (*args))]
-    fn select_columns(&self, args: Vec<PyBackedStr>) -> PyDataFusionResult<Self> {
-        let args = args.iter().map(|s| s.as_ref()).collect::<Vec<&str>>();
-        let df = self.df.as_ref().clone().select_columns(&args)?;
-        Ok(Self::new(df))
-    }
-
     #[pyo3(signature = (*args))]
     fn select_exprs(&self, args: Vec<PyBackedStr>) -> PyDataFusionResult<Self> {
         let args = args.iter().map(|s| s.as_ref()).collect::<Vec<&str>>();

python/datafusion/dataframe.py

@@ -395,17 +395,6 @@ def schema(self) -> pa.Schema:
         """
         return self.df.schema()
 
-    @deprecated(
-        "select_columns() is deprecated. Use :py:meth:`~DataFrame.select` instead"
-    )
-    def select_columns(self, *args: str) -> DataFrame:
-        """Filter the DataFrame by columns.
-
-        Returns:
-            DataFrame only containing the specified columns.
-        """
-        return self.select(*args)
-
     def select_exprs(self, *args: str) -> DataFrame:
         """Project arbitrary list of expression strings into a new DataFrame.