Skip to content

Commit f9ed1d2

Browse files
committed
[hotfix][test] Use Long#compare to replace equivalent statements to improve readability.
1 parent 39c4348 commit f9ed1d2

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/CompactingHashTableTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public boolean equalToReference(Tuple2<Long, String> candidate) {
7070
public int compareToReference(Tuple2<Long, String> candidate) {
7171
long x = ref;
7272
long y = candidate.f0;
73-
return (x < y) ? -1 : ((x == y) ? 0 : 1);
73+
return Long.compare(x, y);
7474
}
7575
};
7676
}

flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public boolean equalToReference(Tuple2<Long, byte[]> candidate) {
9999
public int compareToReference(Tuple2<Long, byte[]> candidate) {
100100
long x = ref;
101101
long y = candidate.f0;
102-
return (x < y) ? -1 : ((x == y) ? 0 : 1);
102+
return Long.compare(x, y);
103103
}
104104
};
105105
}

flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/InPlaceMutableHashTableTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public boolean equalToReference(Tuple2<Long, String> candidate) {
118118
public int compareToReference(Tuple2<Long, String> candidate) {
119119
long x = ref;
120120
long y = candidate.f0;
121-
return (x < y) ? -1 : ((x == y) ? 0 : 1);
121+
return Long.compare(x, y);
122122
}
123123
};
124124
}

flink-tests/src/test/java/org/apache/flink/test/manual/HashTableRecordWidthCombinations.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public boolean equalToReference(Tuple2<Long, byte[]> candidate) {
8383
public int compareToReference(Tuple2<Long, byte[]> candidate) {
8484
long x = ref;
8585
long y = candidate.f0;
86-
return (x < y) ? -1 : ((x == y) ? 0 : 1);
86+
return Long.compare(x, y);
8787
}
8888
};
8989

0 commit comments

Comments
 (0)