Skip to content

Commit 22bdcd1

Browse files
committed
Update comments and frames check logic
1 parent 5eaf554 commit 22bdcd1

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/streaming/controllers/StreamController.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -811,10 +811,10 @@ function StreamController() {
811811
&& !videoModel.isPaused()
812812
&& !videoModel.isStalled()
813813
&& videoModel.getReadyState() >= Constants.VIDEO_ELEMENT_READY_STATES.HAVE_ENOUGH_DATA
814-
&& playbackQuality.totalVideoFrames > 0 // Handles devices (some tvs), where Video Quality API, totalVideoFrames always returns 0
815-
&& playbackQuality.totalVideoFrames < 2147483647 //Handles devices (some tvs), where Video Quality API, totalVideoFrames always returns max value of a 32 bit signed integer
816-
&& playbackQuality.totalVideoFrames !== playbackQuality.droppedVideoFrames // Handles devices (some tvs), where Video Quality API, totalVideoFrames always equals the number of dropped frames
817-
&& playbackQuality.totalVideoFrames <= totalVideoFramesAtLastPlaybackProgress // Total frames should advance with time progression, if not something is wrong
814+
&& playbackQuality.totalVideoFrames > 0 // Handles devices (some TVs), where Video Quality API, totalVideoFrames always returns 0.
815+
&& playbackQuality.totalVideoFrames < 2147483647 //Handles devices (some WebKit TVs), where Video Quality API, totalVideoFrames can return the max value of a 32 bit signed integer becuase the implementation uses totalVideoFrames = mediaTime * framerate.
816+
&& playbackQuality.totalVideoFrames !== playbackQuality.droppedVideoFrames // Handles devices (some TVs), where Video Quality API, totalVideoFrames always equals the number of dropped frames.
817+
&& playbackQuality.totalVideoFrames !== totalVideoFramesAtLastPlaybackProgress // Total frames should advance with time progression, if not something is wrong. On some WebKit TVs this value is reset if the decoder is reinitialised.
818818

819819
if(isVideoFramesNotAdvancing){
820820
if((timeAtLastPlaybackProgress + settings.get().streaming.buffer.videoFramesNotAdvancing.thresholdInSeconds < event.time) && !videoFramesNotAdvancingTriggered){

0 commit comments

Comments
 (0)