Remove 'slow_test' unittest marker (#6569)

## Remove `slow_test` unittest marker

Removes the `slow_test` decorator and its supporting `SKIP_SLOW_TESTS`
env-var mechanism entirely. All previously "slow" test classes now run
unconditionally.

**Changes:**
- Deletes `slow_test()` helper from `beets/test/_common.py`
- Removes all `@_common.slow_test()` usages across test files
- Updates `CONTRIBUTING.rst` to drop the `SKIP_SLOW_TESTS` documentation

Just doing some plumbing removing some unused noise from tests.

Author: snejus

CONTRIBUTING.rst

@@ -315,13 +315,6 @@ Use ``poe`` to run tests:
 
     $ poe test [pytest options]
 
-You can disable a hand-selected set of "slow" tests by setting the environment
-variable ``SKIP_SLOW_TESTS``, for example:
-
-::
-
-    $ SKIP_SLOW_TESTS=1 poe test
-
 Coverage
 ++++++++
 

beets/test/_common.py

@@ -18,7 +18,6 @@
 
 import os
 import sys
-import unittest
 from contextlib import contextmanager
 from typing import TYPE_CHECKING
 
@@ -232,12 +231,3 @@ def system_mock(name):
         yield
     finally:
         platform.system = old_system
-
-
-def slow_test(unused=None):
-    def _id(obj):
-        return obj
-
-    if "SKIP_SLOW_TESTS" in os.environ:
-        return unittest.skip("test is slow")
-    return _id

test/plugins/test_art.py

@@ -761,7 +761,6 @@ def test_fanarttv_only_other_images(self):
             next(self.source.get(album, self.settings, []))
 
 
-@_common.slow_test()
 class ArtImporterTest(UseThePlugin):
     def setUp(self):
         super().setUp()

test/plugins/test_convert.py

@@ -71,7 +71,6 @@ class ConvertTestCase(IOMixin, ConvertMixin, PluginTestCase):
     plugin = "convert"
 
 
-@_common.slow_test()
 class ImportConvertTest(AsIsImporterMixin, ImportHelper, ConvertTestCase):
     def setUp(self):
         super().setUp()
@@ -133,7 +132,6 @@ def run_convert(self, *args):
         return self.run_convert_path(self.item, *args)
 
 
-@_common.slow_test()
 class ConvertCliTest(ConvertTestCase, ConvertCommand):
     def setUp(self):
         super().setUp()
@@ -309,7 +307,6 @@ def test_playlist_entry_keep_new_points_to_destination_file(self):
         self.assert_playlist_entry("converted.ogg", "--keep-new")
 
 
-@_common.slow_test()
 class NeverConvertLossyFilesTest(ConvertTestCase, ConvertCommand):
     """Test the effect of the `never_convert_lossy_files` option."""
 

test/plugins/test_edit.py

@@ -19,7 +19,6 @@
 from beets.dbcore.query import TrueQuery
 from beets.importer import Action
 from beets.library import Item
-from beets.test import _common
 from beets.test.helper import (
     AutotagImportTestCase,
     AutotagStub,
@@ -118,7 +117,6 @@ def run_mocked_command(self, modify_file_args={}, stdin=[], args=[]):
             self.run_command("edit", *args)
 
 
-@_common.slow_test()
 @patch("beets.library.Item.write")
 class EditCommandTest(IOMixin, EditMixin, BeetsTestCase):
     """Black box tests for `beetsplug.edit`. Command line interaction is
@@ -315,7 +313,6 @@ def test_invalid_yaml(self, mock_write):
         assert mock_write.call_count == 0
 
 
-@_common.slow_test()
 class EditDuringImporterTestCase(
     EditMixin, TerminalImportMixin, AutotagImportTestCase
 ):
@@ -332,7 +329,6 @@ def setUp(self):
         self.items_orig = [Item.from_path(f.path) for f in self.import_media]
 
 
-@_common.slow_test()
 class EditDuringImporterNonSingletonTest(EditDuringImporterTestCase):
     def setUp(self):
         super().setUp()
@@ -467,7 +463,6 @@ def test_edit_apply_candidate_singleton(self):
         assert all("match " in i.mb_trackid for i in self.lib.items())
 
 
-@_common.slow_test()
 class EditDuringImporterSingletonTest(EditDuringImporterTestCase):
     def setUp(self):
         super().setUp()

test/test_dbcore.py

@@ -26,7 +26,6 @@
 from beets import dbcore
 from beets.dbcore.db import DBCustomFunctionError, Index
 from beets.library import LibModel
-from beets.test import _common
 from beets.util import cached_classproperty
 
 # Fixture: concrete database and model classes. For migration tests, we
@@ -167,7 +166,6 @@ def _template_funcs(self):
         return {}
 
 
-@_common.slow_test()
 class MigrationTest(unittest.TestCase):
     """Tests the ability to change the database schema between
     versions.

test/test_importer.py

@@ -72,7 +72,6 @@ def track_lib_path(self):
         return self.lib_path / "Tag Artist" / "Tag Album" / "Tag Track 1.mp3"
 
 
-@_common.slow_test()
 class NonAutotaggedImportTest(PathsMixin, AsIsImporterMixin, ImportTestCase):
     db_on_disk = True
 

test/test_logging.py

@@ -10,7 +10,7 @@
 
 import beets.logging as blog
 from beets import plugins, ui
-from beets.test import _common, helper
+from beets.test import helper
 from beets.test.helper import AsIsImporterMixin, ImportTestCase, PluginMixin
 
 
@@ -233,7 +233,6 @@ def test_import_stage_level2(self):
         assert "dummy: debug import_stage" in logs
 
 
-@_common.slow_test()
 class ConcurrentEventsTest(AsIsImporterMixin, ImportTestCase):
     """Similar to LoggingLevelTest but lower-level and focused on multiple
     events interaction. Since this is a bit heavy we don't do it in

test/ui/commands/test_completion.py

@@ -12,7 +12,6 @@
 from ..test_ui import TestPluginTestCase
 
 
-@_common.slow_test()
 @pytest.mark.xfail(
     os.environ.get("GITHUB_ACTIONS") == "true" and sys.platform == "linux",
     reason="Completion is for some reason unhappy on Ubuntu 24.04 in CI",

test/ui/test_ui.py

@@ -80,7 +80,6 @@ def test_uses_database_state_when_old_not_provided(self):
         ]
 
 
-@_common.slow_test()
 class TestPluginTestCase(PluginTestCase):
     plugin = "test"
 
@@ -361,7 +360,6 @@ def test_custom_paths_prepend(self):
         assert pf[1:] == default_formats
 
 
-@_common.slow_test()
 class PluginTest(TestPluginTestCase):
     def test_plugin_command_from_pluginpath(self):
         self.run_command("test")