Merge pull request Pennyw0rth#957 from Pennyw0rth/neff-fix-winrm-errors

Add stderr printing to winrm execution

Author: NeffIsBack

nxc/protocols/winrm.py

@@ -5,7 +5,6 @@
 import logging
 import xml.etree.ElementTree as ET
 
-from io import StringIO
 from datetime import datetime
 from pypsrp.wsman import NAMESPACES
 from pypsrp.client import Client
@@ -261,8 +260,12 @@ def execute(self, payload=None, get_output=False, shell_type="cmd"):
                 return result[0]
             self.logger.success(f"Executed command (shell type: {shell_type})")
             if not self.args.no_output:
-                for line in StringIO(result[0]).readlines():
-                    self.logger.highlight(line.strip())
+                if result[2] == 0:
+                    for line in result[0].replace("\r", "").splitlines():
+                        self.logger.highlight(line.strip())
+                else:
+                    for line in result[1].replace("\r", "").splitlines():
+                        self.logger.fail(line.strip())
 
     def ps_execute(self, payload=None, get_output=False):
         command = payload if payload else self.args.ps_execute