always return str from MSSQLEXEC.execute

Author: azoxlpf

nxc/protocols/mssql.py

@@ -323,7 +323,7 @@ def execute(self, payload=None, get_output=False):
                 self.logger.fail(f"Error during command execution: {self.conn.lastError}")
             else:
                 self.logger.success("Executed command via mssqlexec")
-                for line in (output or "").splitlines():
+                for line in output.splitlines():
                     self.logger.highlight(line.strip())
         return output
 

nxc/protocols/mssql/mssqlexec.py

@@ -10,18 +10,18 @@ def __init__(self, connection, logger):
         self.backuped_options = {}
 
     def execute(self, command):
-        result = None
+        result = ""
 
         self.backup_and_enable("advanced options")
         self.backup_and_enable("xp_cmdshell")
 
         try:
             cmd = f"exec master..xp_cmdshell '{command}'"
             self.logger.debug(f"Attempting to execute query: {cmd}")
-            result = self.mssql_conn.sql_query(cmd)
-            self.logger.debug(f"Raw results from query: {result}")
-            if result:
-                result = "\n".join(line["output"] for line in result if line["output"] != "NULL")
+            raw = self.mssql_conn.sql_query(cmd)
+            self.logger.debug(f"Raw results from query: {raw}")
+            if raw:
+                result = "\n".join(line["output"] for line in raw if line["output"] != "NULL")
                 self.logger.debug(f"Concatenated result together for easier parsing: {result}")
                 # if you prepend SilentlyContinue it will still output the error, but it will still continue on (so it's not silent...)
                 if "Preparing modules for first use" in result and "Completed" not in result: