Skip to content

Commit 1d1c03b

Browse files
XiaoliChanNeffIsBack
authored andcommitted
[winrm] better os info
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
1 parent 7e0c0e0 commit 1d1c03b

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import datetime
44

5+
from impacket.smb3 import WIN_VERSIONS
6+
57

68
def decoder(byte_string, decode_type):
79
if decode_type == "byte":
@@ -11,10 +13,8 @@ def decoder(byte_string, decode_type):
1113

1214

1315
def parse_version(version_bytes):
14-
major_version = version_bytes[0]
15-
minor_version = version_bytes[1]
1616
product_build = decoder(version_bytes[2:4], "int")
17-
return f"{major_version}.{minor_version} Build {product_build}"
17+
return f"{WIN_VERSIONS[product_build]} Build {product_build}"
1818

1919

2020
def parse_target_info(target_info_bytes):

nxc/protocols/winrm.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
from nxc.connection import connection
1717
from nxc.helpers.bloodhound import add_user_bh
1818
from nxc.helpers.misc import gen_random_string
19+
from nxc.helpers.ntlm_parser import parse_challenge
1920
from nxc.logger import NXCAdapter
20-
from nxc.protocols.winrm.winrm_ntlm_parser import parse_challenge
2121

2222

2323
urllib3.disable_warnings()
@@ -54,7 +54,7 @@ def enum_host_info(self):
5454
ntlm_info = parse_challenge(base64.b64decode(self.challenge_header.split(" ")[1].replace(",", "")))
5555
self.domain = ntlm_info["target_info"]["MsvAvDnsDomainName"]
5656
self.hostname = ntlm_info["target_info"]["MsvAvNbComputerName"]
57-
self.server_os = f'Windows {ntlm_info["version"]}'
57+
self.server_os = ntlm_info["version"]
5858
self.logger.extra["hostname"] = self.hostname
5959

6060
self.output_filename = os.path.expanduser(f"~/.nxc/logs/{self.hostname}_{self.host}_{datetime.now().strftime('%Y-%m-%d_%H%M%S')}")

0 commit comments

Comments
 (0)