Functionalise and extract module displaying logic

Author: NeffIsBack

nxc/helpers/misc.py

@@ -4,8 +4,9 @@
 import re
 import inspect
 import os
-
+from termcolor import colored
 from ipaddress import ip_address
+from nxc.logger import nxc_logger
 
 
 def identify_target_file(target_file):
@@ -148,6 +149,17 @@ def detect_if_ip(target):
         return False
 
 
+def display_modules(args, modules):
+    for category, color in {CATEGORY.ENUMERATION: "green", CATEGORY.CREDENTIAL_DUMPING: "cyan", CATEGORY.PRIVILEGE_ESCALATION: "magenta"}.items():
+        # Add category filter for module listing
+        if args.list_modules and args.list_modules.lower() != category.name.lower():
+            continue
+        if len([module for module in modules.values() if module["category"] == category]) > 0:
+            nxc_logger.highlight(colored(f"{category.name}", color, attrs=["bold"]))
+        for name, props in sorted(modules.items()):
+            if props["category"] == category:
+                nxc_logger.display(f"{name:<25} {props['description']}")
+
 class CATEGORY(Enum):
     ENUMERATION = "Enumeration"
     CREDENTIAL_DUMPING = "Credential Dumping"

nxc/netexec.py

@@ -1,8 +1,7 @@
 # PYTHON_ARGCOMPLETE_OK
 import sys
-from termcolor import colored
 from nxc.helpers.logger import highlight
-from nxc.helpers.misc import identify_target_file, CATEGORY
+from nxc.helpers.misc import identify_target_file, display_modules
 from nxc.parsers.ip import parse_targets
 from nxc.parsers.nmap import parse_nmap_xml
 from nxc.parsers.nessus import parse_nessus_file
@@ -168,27 +167,11 @@ def main():
 
         # List low privilege modules
         nxc_logger.highlight("LOW PRIVILEGE MODULES")
-        for category, color in {CATEGORY.ENUMERATION: "green", CATEGORY.CREDENTIAL_DUMPING: "cyan", CATEGORY.PRIVILEGE_ESCALATION: "magenta"}.items():
-            # Add category filter for module listing
-            if args.list_modules and args.list_modules.lower() != category.name.lower():
-                continue
-            if len([module for module in low_privilege_modules.values() if module["category"] == category]) > 0:
-                nxc_logger.highlight(colored(f"{category.name}", color, attrs=["bold"]))
-            for name, props in sorted(low_privilege_modules.items()):
-                if props["category"] == category:
-                    nxc_logger.display(f"{name:<25} {props['description']}")
+        display_modules(args, low_privilege_modules)
 
         # List high privilege modules
         nxc_logger.highlight("\nHIGH PRIVILEGE MODULES (requires admin privs)")
-        for category, color in {CATEGORY.ENUMERATION: "green", CATEGORY.CREDENTIAL_DUMPING: "cyan", CATEGORY.PRIVILEGE_ESCALATION: "magenta"}.items():
-            # Add category filter for module listing
-            if args.list_modules and args.list_modules.lower() != category.name.lower():
-                continue
-            if len([module for module in high_privilege_modules.values() if module["category"] == category]) > 0:
-                nxc_logger.highlight(colored(f"{category.name}", color, attrs=["bold"]))
-            for name, props in sorted(high_privilege_modules.items()):
-                if props["category"] == category:
-                    nxc_logger.display(f"{name:<25} {props['description']}")
+        display_modules(args, high_privilege_modules)
         exit(0)
     elif args.module and args.show_module_options:
         for module in args.module: