fresh schtask_as.py

Signed-off-by: Kahvi-0xFF <46513413+Kahvi-0@users.noreply.github.com>

Author: Kahvi-0

nxc/modules/schtask_as.py

@@ -2,6 +2,7 @@
 from traceback import format_exc
 from nxc.protocols.smb.atexec import TSCH_EXEC
 
+
 class NXCModule:
     """
     Execute a scheduled task remotely as a already connected user by @Defte_
@@ -50,7 +51,6 @@ def options(self, context, module_options):
     name = "schtask_as"
     description = "Remotely execute a scheduled task as a logged on user"
     supported_protocols = ["smb"]
-    multiple_hosts = False
 
     def on_admin_login(self, context, connection):
         self.logger = context.log
@@ -69,18 +69,17 @@ def on_admin_login(self, context, connection):
                 return 1
             else:
                 self.logger.display(f"Uploading {self.binary_to_upload}")
-                binary_file_location = self.tmp_share if self.output_file_location is None else self.output_file_location
                 with open(self.binary_to_upload, "rb") as binary_to_upload:
                     try:
                         self.binary_to_upload_name = os.path.basename(self.binary_to_upload)
-                        connection.conn.putFile(self.share, f"{binary_file_location}{self.binary_to_upload_name}", binary_to_upload.read)
-                        self.logger.success(f"Binary {self.binary_to_upload_name} successfully uploaded in {binary_file_location}{self.binary_to_upload_name}")
+                        connection.conn.putFile(self.share, f"{self.tmp_share}{self.binary_to_upload_name}", binary_to_upload.read)
+                        self.logger.success(f"Binary {self.binary_to_upload_name} successfully uploaded in {self.tmp_share}{self.binary_to_upload_name}")
                     except Exception as e:
-                        self.logger.fail(f"Error writing file to share {binary_file_location}: {e}")
+                        self.logger.fail(f"Error writing file to share {self.tmp_share}: {e}")
                         return 1
 
         # Returnes self.command_to_run or \Windows\temp\BinToExecute.exe depending if BINARY=BinToExecute.exe
-        #self.command_to_run = self.command_to_run if not self.binary_to_upload else f"{self.tmp_share}{self.command_to_run}"
+        self.command_to_run = self.command_to_run if not self.binary_to_upload else f"{self.tmp_share}{self.command_to_run}"
         self.logger.display("Connecting to the remote Service control endpoint")
         try:
             exec_method = TSCH_EXEC(
@@ -97,14 +96,13 @@ def on_admin_login(self, context, connection):
                 self.logger,
                 connection.args.get_output_tries,
                 connection.args.share,
-                self.run_task_as, 
+                self.run_task_as,
                 self.command_to_run,
                 self.output_filename,
                 self.task_name,
                 self.output_file_location,
             )
 
-
             self.logger.display(f"Executing {self.command_to_run} as {self.run_task_as}")
             output = exec_method.execute(self.command_to_run, True)
 
@@ -124,9 +122,7 @@ def on_admin_login(self, context, connection):
         finally:
             if self.binary_to_upload:
                 try:
-                    context.log.success("Sleeping for 10 seconds to let binary run")
-                    sleep(10)
-                    connection.conn.deleteFile(self.share, f"{binary_file_location}{self.binary_to_upload_name}")
-                    context.log.success(f"Binary {binary_file_location}{self.binary_to_upload_name} successfully deleted")
+                    connection.conn.deleteFile(self.share, f"{self.tmp_share}{self.binary_to_upload_name}")
+                    context.log.success(f"Binary {self.binary_to_upload_name} successfully deleted")
                 except Exception as e:
                     context.log.fail(f"Error deleting {self.binary_to_upload_name} on {self.share}: {e}")