Merge pull request Pennyw0rth#1179 from azoxlpf/fix/mssql-fix-infinite-loop

abort rid_brute on invalid connection after failed login

Author: NeffIsBack

nxc/protocols/mssql.py

@@ -423,6 +423,9 @@ def handle_mssql_reply(self):
 
     def rid_brute(self, max_rid=None):
         entries = []
+        if self.conn.lastError:
+            self.logger.fail(f"Cannot perform RID bruteforce due to invalid connection: {self.conn.lastError}")
+            return entries
         if not max_rid:
             max_rid = int(self.args.rid_brute)
 
@@ -435,6 +438,7 @@ def rid_brute(self, max_rid=None):
             domain_sid = SID(bytes.fromhex(raw_domain_sid.decode())).formatCanonical()[:-4]
         except Exception as e:
             self.logger.fail(f"Error parsing SID. Not domain joined?: {e}")
+            return entries
 
         so_far = 0
         simultaneous = 1000