Set empty string as default not boolean

Author: NeffIsBack

nxc/protocols/smb.py

@@ -1031,11 +1031,11 @@ def qwinsta(self):
             CONNTIME="",
             DISCTIME="",
         )
-
         result = [header, header2]
 
+        # Check if we need to filter for usernames
         usernames = None
-        if self.args.qwinsta and self.args.qwinsta is not True:
+        if self.args.qwinsta:
             arg = self.args.qwinsta
             if os.path.isfile(arg):
                 with open(arg) as f:

nxc/protocols/smb/proto_args.py

@@ -53,7 +53,7 @@ def proto_args(parser, parents):
     mapping_enum_group.add_argument("--local-groups", nargs="?", const="", metavar="GROUP", help="Enumerate local groups, if a group is specified then its members are Enumerated")
     mapping_enum_group.add_argument("--pass-pol", action="store_true", help="dump password policy")
     mapping_enum_group.add_argument("--rid-brute", nargs="?", type=int, const=4000, metavar="MAX_RID", help="Enumerate users by bruteforcing RIDs")
-    mapping_enum_group.add_argument("--qwinsta", type=str, nargs="?", const=True, help="Enumerate user sessions. If a username is given, filter for it; if a file is given, filter for listed usernames. If no value is given, list all.")
+    mapping_enum_group.add_argument("--qwinsta", type=str, nargs="?", const="", help="Enumerate user sessions. If a username is given, filter for it; if a file is given, filter for listed usernames. If no value is given, list all.")
     mapping_enum_group.add_argument("--tasklist", action="store_true", help="Enumerate running processes")
 
     wmi_group = smb_parser.add_argument_group("WMI", "Options for WMI Queries")