Skip to content

Commit 9f906ea

Browse files
authored
Merge pull request Pennyw0rth#694 from cyberG33k02/false-negative-fix
fix(ntlm): include server hostname in Workstation field of Authentication
2 parents 07b4eba + 4da1954 commit 9f906ea

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

nxc/protocols/winrm.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,9 @@ def check_if_admin(self):
145145
return True
146146

147147
def plaintext_login(self, domain, username, password):
148+
# Add server hostname to the Workstation field in NTLM Authenticate Message (Message 3)
149+
# This helps fix false negatives during NTLM auth — see issue #694 for details
150+
os.environ["NETBIOS_COMPUTER_NAME"] = self.hostname
148151
self.admin_privs = False
149152
self.password = password
150153
self.username = username
@@ -183,6 +186,9 @@ def plaintext_login(self, domain, username, password):
183186
return False
184187

185188
def hash_login(self, domain, username, ntlm_hash):
189+
# Add server hostname to the Workstation field in NTLM Authenticate Message (Message 3)
190+
# This helps fix false negatives during NTLM auth — see issue #694 for details
191+
os.environ["NETBIOS_COMPUTER_NAME"] = self.hostname
186192
self.admin_privs = False
187193
lmhash = "00000000000000000000000000000000"
188194
nthash = ""

0 commit comments

Comments
 (0)