Skip to content

Commit c689eb0

Browse files
authored
Merge pull request Pennyw0rth#851 from azoxlpf/fix/nxdomain-duplicate-logs
Stop logging NXDOMAIN multiple times in DNS resolution
2 parents 0bc8101 + 58428af commit c689eb0

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

nxc/protocols/ldap.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -858,13 +858,15 @@ def resolve_and_display_hostname(name, domain_name=None):
858858
self.logger.highlight(f"{prefix}{name} NS = {colored(rdata.to_text(), host_info_colors[0])}")
859859
return
860860
except resolver.NXDOMAIN:
861-
self.logger.fail(f"{prefix}{name} = Host not found (NXDOMAIN)")
861+
self.logger.fail(f"{prefix}{name} ({record_type}) = Host not found (NXDOMAIN)")
862862
except resolver.Timeout:
863-
self.logger.fail(f"{prefix}{name} = Connection timed out")
863+
self.logger.fail(f"{prefix}{name} ({record_type}) = Connection timed out")
864864
except resolver.NoAnswer:
865-
self.logger.fail(f"{prefix}{name} = DNS server did not respond")
865+
self.logger.fail(f"{prefix}{name} ({record_type}) = DNS server did not respond")
866+
except resolver.NoNameservers:
867+
self.logger.fail(f"{prefix}{name} ({record_type}) = No nameservers available")
866868
except Exception as e:
867-
self.logger.fail(f"{prefix}{name} encountered an unexpected error: {e}")
869+
self.logger.fail(f"{prefix}{name} ({record_type}) encountered an unexpected error: {e}")
868870
except Exception as e:
869871
self.logger.fail(f"Skipping item(dNSHostName) {prefix}{name}, error: {e}")
870872

0 commit comments

Comments
 (0)