Increase readability and don't force quit on error

Author: NeffIsBack

nxc/modules/procdump.py

@@ -4,7 +4,6 @@
 
 import base64
 import re
-import sys
 import pypykatz
 from nxc.helpers.bloodhound import add_user_bh
 from nxc.paths import TMP_PATH
@@ -79,15 +78,18 @@ def on_admin_login(self, context, connection):
         else:
             context.log.fail("Process lsass.exe error un dump, try with verbose")
 
-        if dump:
+        if not dump:
+            self.delete_procdump_binary(connection, context)
+            return
+        else:
             regex = r"([A-Za-z0-9-]*.dmp)"
             matches = re.search(regex, str(p), re.MULTILINE)
             machine_name = ""
             if matches:
                 machine_name = matches.group()
             else:
                 context.log.display("Error getting the lsass.dmp file name")
-                sys.exit(1)
+                return
 
             context.log.display(f"Copy {machine_name} to host")
 
@@ -149,12 +151,9 @@ def on_admin_login(self, context, connection):
                 except Exception as e:
                     context.log.fail("Error openning dump file", str(e))
 
-        else:
-            self.delete_procdump_binary(connection, context)
-
     def delete_procdump_binary(self, connection, context):
         try:
             connection.conn.deleteFile(self.share, self.tmp_share + self.procdump)
             context.log.success(f"Deleted procdump file on the {self.share} share")
         except Exception as e:
-            context.log.fail(f"Error deleting procdump file on share {self.share}: {e}")
+            context.log.fail(f"Error deleting procdump file on share {self.share}: {e}")