update passpol

Author: mpgn

nxc/helpers/misc.py

@@ -149,6 +149,10 @@ def detect_if_ip(target):
 
 
 def d2b(a):
+    """
+    This function is used to convert password property flags from decimal to binary
+    format for easier interpretation of individual flag bits.
+    """
     tbin = []
     while a:
         tbin.append(a % 2)
@@ -162,6 +166,22 @@ def d2b(a):
 
 
 def convert(low, high, lockout=False):
+    """
+    Convert Windows FILETIME (64-bit) values to human-readable time strings.
+    
+    Windows stores time intervals as 64-bit values representing 100-nanosecond
+    intervals since January 1, 1601. This function converts these values to
+    readable format like "30 days 5 hours 15 minutes".
+    
+    Args:
+        low (int): Low 32 bits of the FILETIME value
+        high (int): High 32 bits of the FILETIME value  
+        lockout (bool): If True, treats the value as a lockout duration (simpler conversion)
+        
+    Returns:
+        str: Human-readable time string (e.g., "42 days 5 hours 30 minutes") or
+             special values like "Not Set", "None", or "[-] Invalid TIME"
+    """
     time = ""
     tmp = 0
 

nxc/protocols/ldap.py

@@ -1531,7 +1531,7 @@ def ldap_to_filetime(ldap_time):
 
             # Convert password properties using existing d2b function
             pwd_properties = policy.get("pwdProperties", "0")
-            pass_prop = d2b(int(pwd_properties)) if pwd_properties != "0" else "None"
+            pass_prop = d2b(int(pwd_properties)) if pwd_properties != "0" else "000000"
 
             # Use the same formatting and constants as SMB passpol
             PASSCOMPLEX = {

nxc/protocols/smb/passpol.py

@@ -2,64 +2,8 @@
 
 from impacket.dcerpc.v5.rpcrt import DCERPC_v5
 from impacket.dcerpc.v5 import transport, samr
-from time import strftime, gmtime
 from nxc.logger import nxc_logger
-
-
-def d2b(a):
-    tbin = []
-    while a:
-        tbin.append(a % 2)
-        a //= 2
-
-    t2bin = tbin[::-1]
-    if len(t2bin) != 8:
-        for _x in range(6 - len(t2bin)):
-            t2bin.insert(0, 0)
-    return "".join([str(g) for g in t2bin])
-
-
-def convert(low, high, lockout=False):
-    time = ""
-    tmp = 0
-
-    if (low == 0 and high == -0x8000_0000) or (low == 0 and high == -0x8000_0000_0000_0000):
-        return "Not Set"
-    if low == 0 and high == 0:
-        return "None"
-
-    if not lockout:
-        if low != 0:
-            high = abs(high + 1)
-        else:
-            high = abs(high)
-            low = abs(low)
-
-        tmp = low + (high << 32)  # convert to 64bit int
-        tmp *= 1e-7  # convert to seconds
-    else:
-        tmp = abs(high) * (1e-7)
-
-    try:
-        minutes = int(strftime("%M", gmtime(tmp)))
-        hours = int(strftime("%H", gmtime(tmp)))
-        days = int(strftime("%j", gmtime(tmp))) - 1
-    except ValueError:
-        return "[-] Invalid TIME"
-
-    if days > 1:
-        time += f"{days} days "
-    elif days == 1:
-        time += f"{days} day "
-    if hours > 1:
-        time += f"{hours} hours "
-    elif hours == 1:
-        time += f"{hours} hour "
-    if minutes > 1:
-        time += f"{minutes} minutes "
-    elif minutes == 1:
-        time += f"{minutes} minute "
-    return time
+from nxc.helpers.misc import convert, d2b
 
 
 class PassPolDump: