Merge pull request Pennyw0rth#470 from Chocapikk/main

FIX `a bytes-like object is required, not str` in `nxc/protocols/smb.py`

Author: NeffIsBack

nxc/protocols/smb.py

@@ -258,6 +258,10 @@ def enum_host_info(self):
         except KeyError:
             self.logger.debug("Error getting server information...")
 
+        # Handle cases where server_os is returned as bytes, such as when accidentally scanning a machine running Responder
+        if isinstance(self.server_os.lower(), bytes):
+            self.server_os = self.server_os.decode("utf-8")
+
         if "Windows 6.1" in self.server_os and self.server_os_build == 0 and self.os_arch == 0:
             self.server_os = "Unix - Samba"
         elif self.server_os_build == 0 and self.os_arch == 0:
@@ -266,9 +270,6 @@ def enum_host_info(self):
 
         self.logger.extra["hostname"] = self.hostname
 
-        if isinstance(self.server_os.lower(), bytes):
-            self.server_os = self.server_os.decode("utf-8")
-
         try:
             self.signing = self.conn.isSigningRequired() if self.smbv1 else self.conn._SMBConnection._Connection["RequireSigning"]
         except Exception as e: