You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update the pull request template to clarify AI usage and some additional helpful asks
Signed-off-by: Marshall Hallenbeck <Marshall.Hallenbeck@gmail.com>
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+5-3Lines changed: 5 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -12,6 +12,7 @@ Insert an "x" inside the brackets for relevant items (do not delete options)
12
12
-[ ] Deprecation of feature or functionality
13
13
-[ ] This change requires a documentation update
14
14
-[ ] This requires a third party update (such as Impacket, Dploot, lsassy, etc)
15
+
-[ ] This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)
15
16
16
17
## Setup guide for the review
17
18
Please provide guidance on what setup is needed to test the introduced changes, such as your locally running machine Python version & OS, as well as the target(s) you tested against, including software versions.
@@ -24,7 +25,8 @@ In particular:
24
25
25
26
## Screenshots (if appropriate):
26
27
Screenshots are always nice to have and can give a visual representation of the change.
27
-
If appropriate include before and after screenshot(s) to show which results are to be expected.
28
+
If appropriate, include before and after screenshot(s) to show which results are to be expected.
29
+
Including the commands ran in any screenshots as a `codeblock` in this section is also helpful.
28
30
29
31
## Checklist:
30
32
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
@@ -33,6 +35,6 @@ Insert an "x" inside the brackets for completed and relevant items (do not delet
33
35
-[ ] I have added or updated the `tests/e2e_commands.txt` file if necessary (new modules or features are _required_ to be added to the e2e tests)
34
36
-[ ] If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
35
37
-[ ] I have linked relevant sources that describes the added technique (blog posts, documentation, etc)
36
-
-[ ] I have performed a self-review of my own code
37
-
-[ ] I have commented my code, particularly in hard-to-understand areas
38
+
-[ ] I have performed a self-review of my own code (_not_ an AI review)
39
+
-[ ] I have commented my code, particularly in hard-to-understand areas (do not add useless comments)
38
40
-[ ] I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)
0 commit comments