also added multi-file get

Author: wumb0

nxc/protocols/smb.py

@@ -1263,10 +1263,8 @@ def put_file(self):
         else:
             self.put_file_single(*files)
 
-    def get_file(self):
+    def get_file_single(self, remote_path, download_path):
         share_name = self.args.share
-        remote_path = self.args.get_file[0]
-        download_path = self.args.get_file[1]
         self.logger.display(f'Copying "{remote_path}" to "{download_path}"')
         if self.args.append_host:
             download_path = f"{self.hostname}-{remote_path}"
@@ -1279,6 +1277,14 @@ def get_file(self):
                 if os.path.getsize(download_path) == 0:
                     os.remove(download_path)
 
+    def get_file(self):
+        files = self.args.get_file
+        if isinstance(files, list):
+            for src, dest in files:
+                self.get_file_single(src, dest)
+        else:
+            self.get_file_single(*files)
+
     def enable_remoteops(self):
         try:
             self.remote_ops = RemoteOperations(self.conn, self.kerberos, self.kdcHost)

nxc/protocols/smb/proto_args.py

@@ -60,7 +60,7 @@ def proto_args(parser, std_parser, module_parser):
 
     tgroup = smb_parser.add_argument_group("Files", "Options for put and get remote files")
     tgroup.add_argument("--put-file", action="append", nargs=2, metavar="FILE", help="Put a local file into remote target, ex: whoami.txt \\\\Windows\\\\Temp\\\\whoami.txt")
-    tgroup.add_argument("--get-file", nargs=2, metavar="FILE", help="Get a remote file, ex: \\\\Windows\\\\Temp\\\\whoami.txt whoami.txt")
+    tgroup.add_argument("--get-file", action="append", nargs=2, metavar="FILE", help="Get a remote file, ex: \\\\Windows\\\\Temp\\\\whoami.txt whoami.txt")
     tgroup.add_argument("--append-host", action="store_true", help="append the host to the get-file filename")
 
     cgroup = smb_parser.add_argument_group("Command Execution", "Options for executing commands")