Merge pull request mercadopago#49 from WhyNotHugo/deduplicate-client-functions

Deduplicate some client functions

Author: rhames07

mercadopago/http/http_client.py

@@ -11,57 +11,34 @@ class HttpClient():
     Default implementation to call all REST API's
     """
 
-    def __init__(self):
-        pass
+    def request(self, method, url, maxretries=None, **kwargs):
+        """Makes a call to the API.
 
-    @staticmethod
-    def __get_session(max_retries):
+        All **kwargs are passed verbatimm to ``requests.request``.
+        """
         retry_strategy = Retry(
-            total=max_retries,
+            total=maxretries,
             status_forcelist=[429, 500, 502, 503, 504]
         )
         http = requests.Session()
         http.mount("https://", HTTPAdapter(max_retries=retry_strategy))
-        return http
-
-    def get(self, url, headers, params=None, timeout=None, maxretries=None): #pylint: disable=missing-function-docstring, too-many-arguments
-        with self.__get_session(maxretries) as session:
-            api_result = session.get(url, params=params, headers=headers, timeout=timeout)
+        with http as session:
+            api_result = session.request(method, url, **kwargs)
             response = {
                 "status": api_result.status_code,
                 "response": api_result.json()
             }
 
         return response
 
-    def post(self, url, headers, data=None, params=None, timeout=None, maxretries=None): #pylint: disable=missing-function-docstring, too-many-arguments
-        with self.__get_session(maxretries) as session:
-            api_result = session.post(url, params=params, data=data,
-            headers=headers, timeout=timeout)
-            response = {
-                "status": api_result.status_code,
-                "response": api_result.json()
-            }
-
-        return response
-
-    def put(self, url, headers, data=None, params=None, timeout=None, maxretries=None): #pylint: disable=missing-function-docstring, too-many-arguments
-        with self.__get_session(maxretries) as session:
-            api_result = session.put(url, params=params, data=data,
-            headers=headers, timeout=timeout)
-            response = {
-                "status": api_result.status_code,
-                "response": api_result.json()
-            }
+    def get(self, url, headers, params=None, timeout=None, maxretries=None):  # pylint: disable=missing-function-docstring, too-many-arguments
+        return self.request("GET", url=url, headers=headers, params=params, timeout=timeout, maxretries=maxretries)
 
-        return response
+    def post(self, url, headers, data=None, params=None, timeout=None, maxretries=None):  # pylint: disable=missing-function-docstring, too-many-arguments
+        return self.request("POST", url=url, headers=headers, data=data, params=params, timeout=timeout, maxretries=maxretries)
 
-    def delete(self, url, headers, params=None, timeout=None, maxretries=None): #pylint: disable=missing-function-docstring, too-many-arguments
-        with self.__get_session(maxretries) as session:
-            api_result = session.delete(url, params=params, headers=headers, timeout=timeout)
-            response = {
-                "status": api_result.status_code,
-                "response": api_result.json()
-            }
+    def put(self, url, headers, data=None, params=None, timeout=None, maxretries=None):  # pylint: disable=missing-function-docstring, too-many-arguments
+        return self.request("PUT", url=url, headers=headers, data=data, params=params, timeout=timeout, maxretries=maxretries)
 
-        return response
+    def delete(self, url, headers, params=None, timeout=None, maxretries=None):  # pylint: disable=missing-function-docstring, too-many-arguments
+        return self.request("DELETE", url=url, headers=headers, params=params, timeout=timeout, maxretries=maxretries)