Skip to content

Commit 3da07d8

Browse files
committed
added dependency log to resolver
1 parent 8352be1 commit 3da07d8

File tree

2 files changed

+26
-20
lines changed

2 files changed

+26
-20
lines changed

crates/wasm-pkg-common/src/config.rs

Lines changed: 24 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -181,27 +181,33 @@ impl Config {
181181
/// - The default registry
182182
/// - Hard-coded fallbacks for certain well-known namespaces
183183
pub fn resolve_registry(&self, package: &PackageRef) -> Option<&Registry> {
184-
if let Some(RegistryMapping::Registry(reg)) = self.package_registry_overrides.get(package) {
185-
Some(reg)
186-
} else if let Some(RegistryMapping::Custom(custom)) =
187-
self.package_registry_overrides.get(package)
184+
if let Some(reg) = self
185+
.package_registry_overrides
186+
.get(package)
187+
.map(|m| match m {
188+
RegistryMapping::Registry(reg) => reg,
189+
RegistryMapping::Custom(custom) => &custom.registry,
190+
})
188191
{
189-
Some(&custom.registry)
190-
} else if let Some(RegistryMapping::Registry(reg)) =
191-
self.namespace_registries.get(package.namespace())
192-
{
193-
Some(reg)
194-
} else if let Some(RegistryMapping::Custom(custom)) =
195-
self.namespace_registries.get(package.namespace())
192+
return Some(reg);
193+
}
194+
195+
if let Some(reg) = self
196+
.namespace_registries
197+
.get(package.namespace())
198+
.map(|m| match m {
199+
RegistryMapping::Registry(reg) => reg,
200+
RegistryMapping::Custom(custom) => &custom.registry,
201+
})
196202
{
197-
Some(&custom.registry)
198-
} else if let Some(reg) = self.default_registry.as_ref() {
199-
Some(reg)
200-
} else if let Some(reg) = self.fallback_namespace_registries.get(package.namespace()) {
201-
Some(reg)
202-
} else {
203-
None
203+
return Some(reg);
204204
}
205+
206+
if let Some(reg) = self.default_registry.as_ref() {
207+
return Some(reg);
208+
}
209+
210+
self.fallback_namespace_registries.get(package.namespace())
205211
}
206212

207213
/// Returns the default registry.

crates/wasm-pkg-core/src/resolver.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ impl std::fmt::Display for Dependency {
5151

5252
write!(
5353
f,
54-
"{{ registry = {registry} package = {}@{version} }}",
54+
"{{registry=\"{registry}\" package=\"{}@{version}\"}}",
5555
name.as_deref().unwrap_or("_:_"),
5656
)
5757
}
@@ -435,7 +435,7 @@ impl<'a> DependencyResolver<'a> {
435435
if !force_override
436436
&& (self.resolutions.contains_key(name) || self.dependencies.contains_key(name))
437437
{
438-
tracing::debug!(%name, "dependency already exists and override is not set, ignoring");
438+
tracing::debug!(%name, %dependency, "dependency already exists and override is not set, ignoring");
439439
return Ok(());
440440
}
441441
self.dependencies.insert(

0 commit comments

Comments
 (0)