Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit 074d8ef

Browse files
author
Kevin Wiesmüller
authored
avoid expensive clones in splitCreateTimeSeriesRequest (#299)
1 parent dfce60d commit 074d8ef

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

stats.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -639,6 +639,8 @@ var createServiceTimeSeries = func(ctx context.Context, c *monitoring.MetricClie
639639
func splitCreateTimeSeriesRequest(req *monitoringpb.CreateTimeSeriesRequest) (*monitoringpb.CreateTimeSeriesRequest, *monitoringpb.CreateTimeSeriesRequest) {
640640
var serviceReq, nonServiceReq *monitoringpb.CreateTimeSeriesRequest
641641
serviceTs, nonServiceTs := splitTimeSeries(req.TimeSeries)
642+
// reset timeseries as we just split it to avoid cloning it in the calls below
643+
req.TimeSeries = nil
642644
if len(serviceTs) > 0 {
643645
serviceReq = proto.Clone(req).(*monitoringpb.CreateTimeSeriesRequest)
644646
serviceReq.TimeSeries = serviceTs

0 commit comments

Comments
 (0)