Use GitHub Actions and golangci-lint (#310)

* Use GitHub Actions and golangci-lint

* Bump golang for Cloud Build

Author: lucacome

.github/workflows/ci.yaml

@@ -0,0 +1,35 @@
+name: "CI"
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+jobs:
+  staticcheck:
+    name: "Staticcheck"
+    runs-on: ubuntu-22.04
+    steps:
+    - name: Checkout Repository
+      uses: actions/checkout@v3
+    - name: Setup Golang Environment
+      uses: actions/setup-go@v3
+      with:
+        go-version-file: go.mod
+        cache: true
+    - name: Run Staticcheck
+      uses: dominikh/staticcheck-action@v1.2.0
+  lint:
+    name: "Lint"
+    runs-on: ubuntu-22.04
+    steps:
+    - name: Checkout Repository
+      uses: actions/checkout@v3
+    - name: Setup Golang Environment
+      uses: actions/setup-go@v3
+      with:
+        go-version-file: go.mod
+        cache: true
+    - name: Run Lint
+      uses: golangci/golangci-lint-action@v3

.golangci.yml

@@ -0,0 +1,20 @@
+linters-settings:
+  misspell:
+    locale: US
+  revive:
+    ignore-generated-header: true
+
+linters:
+    enable:
+    - goimports
+    - govet
+    - gofmt
+    - revive
+    - misspell
+    disable-all: true
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0
+  exclude-use-default: false
+run:
+  timeout: 5m

Makefile

@@ -8,23 +8,19 @@ ALL_PKGS := $(shell go list $(sort $(dir $(ALL_SRC))))
 GOTEST_OPT?=-v -race -timeout 30s
 GOTEST_OPT_WITH_COVERAGE = $(GOTEST_OPT) -coverprofile=coverage.txt -covermode=atomic
 GOTEST=go test
-GOFMT=gofmt
-GOLINT=golint
-GOIMPORTS=goimports
-GOVET=go vet
 EMBEDMD=embedmd
 STATICCHECK=staticcheck
 # TODO decide if we need to change these names.
 README_FILES := $(shell find . -name '*README.md' | sort | tr '\n' ' ')
 
-.DEFAULT_GOAL := defaul-goal
+.DEFAULT_GOAL := default-goal
 
-.PHONY: defaul-goal
-defaul-goal: fmt lint vet embedmd goimports staticcheck test
+.PHONY: default-goal
+default-goal: lint embedmd staticcheck test
 
 # TODO: enable test-with-cover when find out why "scripts/check-test-files.sh: 4: set: Illegal option -o pipefail"
 .PHONY: ci
-ci: fmt lint vet embedmd goimports staticcheck test test-386 test-with-coverage
+ci: embedmd test test-386 test-with-coverage
 
 all-pkgs:
 	@echo $(ALL_PKGS) | tr ' ' '\n' | sort
@@ -56,40 +52,10 @@ test-with-cover:
 	$(GOTEST) $(GOTEST_OPT_WITH_COVERAGE) $(ALL_PKGS)
 	go tool cover -html=coverage.txt -o coverage.html
 
-.PHONY: fmt
-fmt:
-	@FMTOUT=`$(GOFMT) -s -l $(ALL_SRC) 2>&1`; \
-	if [ "$$FMTOUT" ]; then \
-		echo "$(GOFMT) FAILED => gofmt the following files:\n"; \
-		echo "$$FMTOUT\n"; \
-		exit 1; \
-	else \
-	    echo "Fmt finished successfully"; \
-	fi
-
 .PHONY: lint
 lint:
-	@LINTOUT=`$(GOLINT) $(ALL_PKGS) 2>&1`; \
-	if [ "$$LINTOUT" ]; then \
-		echo "$(GOLINT) FAILED => clean the following lint errors:\n"; \
-		echo "$$LINTOUT\n"; \
-		exit 1; \
-	else \
-	    echo "Lint finished successfully"; \
-	fi
+	golangci-lint run
 
-.PHONY: vet
-vet:
-    # TODO: Understand why go vet downloads "github.com/google/go-cmp v0.2.0"
-	@VETOUT=`$(GOVET) ./... | grep -v "go: downloading" 2>&1`; \
-	if [ "$$VETOUT" ]; then \
-		echo "$(GOVET) FAILED => go vet the following files:\n"; \
-		echo "$$VETOUT\n"; \
-		exit 1; \
-	else \
-	    echo "Vet finished successfully"; \
-	fi
-	
 .PHONY: embedmd
 embedmd:
 	@EMBEDMDOUT=`$(EMBEDMD) -d $(README_FILES) 2>&1`; \
@@ -101,25 +67,12 @@ embedmd:
 	    echo "Embedmd finished successfully"; \
 	fi
 
-.PHONY: goimports
-goimports:
-	@IMPORTSOUT=`$(GOIMPORTS) -d . 2>&1`; \
-	if [ "$$IMPORTSOUT" ]; then \
-		echo "$(GOIMPORTS) FAILED => fix the following goimports errors:\n"; \
-		echo "$$IMPORTSOUT\n"; \
-		exit 1; \
-	else \
-	    echo "Goimports finished successfully"; \
-	fi
-
 .PHONY: staticcheck
 staticcheck:
 	$(STATICCHECK) ./...
 
 .PHONY: install-tools
 install-tools:
-	GO111MODULE=on go install \
-		golang.org/x/lint/golint \
-		golang.org/x/tools/cmd/goimports \
-		github.com/rakyll/embedmd \
-		honnef.co/go/tools/cmd/staticcheck
+	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.50.1
+	go install github.com/rakyll/embedmd@latest
+	go install honnef.co/go/tools/cmd/staticcheck@2022.1.3

cloudbuild.yaml

@@ -1,4 +1,4 @@
 steps:
-  - name: golang:1.17
+  - name: golang:1.19
     args: ["make", "install-tools", "ci"]
 logsBucket: gs://opentelemetry-ops-e2e-cloud-build-logs

example_test.go

@@ -63,7 +63,6 @@ func Example_defaults() {
 }
 
 func Example_gKE() {
-
 	// This example shows how to set up a Stackdriver exporter suitable for
 	// monitoring a GKE container.
 

go.mod

@@ -3,38 +3,30 @@ module contrib.go.opencensus.io/exporter/stackdriver
 go 1.17
 
 require (
-	cloud.google.com/go/compute v1.5.0
+	cloud.google.com/go/compute v1.6.1
 	cloud.google.com/go/monitoring v1.1.0
 	cloud.google.com/go/trace v1.0.0
 	github.com/aws/aws-sdk-go v1.43.31
 	github.com/census-instrumentation/opencensus-proto v0.3.0
 	github.com/golang/protobuf v1.5.2
-	github.com/google/go-cmp v0.5.7
+	github.com/google/go-cmp v0.5.9
 	github.com/jstemmer/go-junit-report v0.9.1
 	github.com/prometheus/prometheus v0.35.0
-	github.com/rakyll/embedmd v0.0.0-20171029212350-c8060a0752a2
 	go.opencensus.io v0.23.0
-	golang.org/x/lint v0.0.0-20210508222113-6edffad5e616
-	golang.org/x/net v0.0.0-20220325170049-de3da57026de
-	golang.org/x/oauth2 v0.0.0-20220309155454-6242fa91716a
-	golang.org/x/tools v0.1.10
-	google.golang.org/api v0.74.0
-	google.golang.org/genproto v0.0.0-20220324131243-acbaeb5b85eb
-	google.golang.org/grpc v1.45.0
+	golang.org/x/net v0.1.0
+	golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5
+	google.golang.org/api v0.81.0
+	google.golang.org/genproto v0.0.0-20220519153652-3a47de7e79bd
+	google.golang.org/grpc v1.46.2
 	google.golang.org/protobuf v1.28.0
-	honnef.co/go/tools v0.0.1-2020.1.4
 )
 
 require (
-	github.com/BurntSushi/toml v0.3.1 // indirect
 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
-	github.com/googleapis/gax-go/v2 v2.2.0 // indirect
+	github.com/googleapis/gax-go/v2 v2.4.0 // indirect
 	github.com/jmespath/go-jmespath v0.4.0 // indirect
-	github.com/pmezard/go-difflib v1.0.0 // indirect
-	golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3 // indirect
-	golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect
-	golang.org/x/sys v0.0.0-20220328115105-d36c6a25d886 // indirect
-	golang.org/x/text v0.3.7 // indirect
-	golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
+	golang.org/x/sync v0.0.0-20220819030929-7fc1605a5dde // indirect
+	golang.org/x/sys v0.1.0 // indirect
+	golang.org/x/text v0.4.0 // indirect
 	google.golang.org/appengine v1.6.7 // indirect
 )