Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit 7cac5ce

Browse files
songy23bogdandrutu
authored andcommitted
Revert "Remove support for exporting ViewData (#188)" (#191)
* Revert "Remove support for exporting ViewData (#188)" This reverts commit 4b7f306. * Deprecate ExportView * Keep the changes in equivalence_test and example
1 parent 211cb75 commit 7cac5ce

5 files changed

Lines changed: 1753 additions & 2 deletions

File tree

example_test.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ func Example_defaults() {
3434
log.Fatal(err)
3535
}
3636

37+
// Export to Stackdriver Monitoring.
38+
if err = exporter.StartMetricsExporter(); err != nil {
39+
log.Fatal(err)
40+
}
41+
3742
// Subscribe views to see stats in Stackdriver Monitoring.
3843
if err := view.Register(
3944
ochttp.ClientLatencyView,
@@ -73,7 +78,7 @@ func Example_gKE() {
7378
zone = "unknown"
7479
}
7580

76-
_, err = stackdriver.NewExporter(stackdriver.Options{
81+
exporter, err := stackdriver.NewExporter(stackdriver.Options{
7782
ProjectID: "google-project-id",
7883
// Set a MonitoredResource that represents a GKE container.
7984
Resource: &monitoredres.MonitoredResource{
@@ -100,4 +105,9 @@ func Example_gKE() {
100105
if err != nil {
101106
log.Fatal(err)
102107
}
108+
109+
// Register so that views are exported.
110+
if err = exporter.StartMetricsExporter(); err != nil {
111+
log.Fatal(err)
112+
}
103113
}

stackdriver.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,13 @@ func NewExporter(o Options) (*Exporter, error) {
341341
}, nil
342342
}
343343

344+
// ExportView exports to the Stackdriver Monitoring if view data
345+
// has one or more rows.
346+
// Deprecated: use ExportMetrics and StartMetricsExporter instead.
347+
func (e *Exporter) ExportView(vd *view.Data) {
348+
e.statsExporter.ExportView(vd)
349+
}
350+
344351
// ExportMetricsProto exports OpenCensus Metrics Proto to Stackdriver Monitoring synchronously,
345352
// without de-duping or adding proto metrics to the bundler.
346353
func (e *Exporter) ExportMetricsProto(ctx context.Context, node *commonpb.Node, rsc *resourcepb.Resource, metrics []*metricspb.Metric) error {

stackdriver_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import (
2525

2626
"contrib.go.opencensus.io/exporter/stackdriver/internal/testpb"
2727
"go.opencensus.io/plugin/ochttp"
28+
"go.opencensus.io/stats/view"
2829
"go.opencensus.io/trace"
2930
"golang.org/x/net/context/ctxhttp"
3031
)
@@ -47,6 +48,8 @@ func TestExport(t *testing.T) {
4748

4849
trace.RegisterExporter(exporter)
4950
defer trace.UnregisterExporter(exporter)
51+
view.RegisterExporter(exporter)
52+
defer view.UnregisterExporter(exporter)
5053

5154
trace.ApplyConfig(trace.Config{DefaultSampler: trace.AlwaysSample()})
5255

@@ -110,6 +113,8 @@ func TestGRPC(t *testing.T) {
110113

111114
trace.RegisterExporter(exporter)
112115
defer trace.UnregisterExporter(exporter)
116+
view.RegisterExporter(exporter)
117+
defer view.UnregisterExporter(exporter)
113118

114119
trace.ApplyConfig(trace.Config{DefaultSampler: trace.AlwaysSample()})
115120

0 commit comments

Comments
 (0)