Remove outdated option GetMonitoredResource (#186)

Author: songy23

stackdriver.go

@@ -62,7 +62,6 @@ import (
 	"contrib.go.opencensus.io/exporter/stackdriver/monitoredresource"
 	"go.opencensus.io/resource"
 	"go.opencensus.io/stats/view"
-	"go.opencensus.io/tag"
 	"go.opencensus.io/trace"
 	"golang.org/x/oauth2/google"
 	"google.golang.org/api/option"
@@ -242,21 +241,6 @@ type Options struct {
 	// Timeout for all API calls. If not set, defaults to 5 seconds.
 	Timeout time.Duration
 
-	// GetMonitoredResource may be provided to supply the details of the
-	// monitored resource dynamically based on the tags associated with each
-	// data point. Most users will not need to set this, but should instead
-	// set the MonitoredResource field.
-	//
-	// GetMonitoredResource may add or remove tags by returning a new set of
-	// tags. It is safe for the function to mutate its argument and return it.
-	//
-	// See the documentation on the MonitoredResource field for guidance on the
-	// interaction between monitored resources and labels.
-	//
-	// The MonitoredResource field is ignored if this field is set to a non-nil
-	// value.
-	GetMonitoredResource func(*view.View, []tag.Tag) ([]tag.Tag, monitoredresource.Interface)
-
 	// ReportingInterval sets the interval between reporting metrics.
 	// If it is set to zero then default value is used.
 	ReportingInterval time.Duration

stats.go

@@ -163,10 +163,6 @@ func (e *statsExporter) stopMetricsReader() {
 }
 
 func (e *statsExporter) getMonitoredResource(v *view.View, tags []tag.Tag) ([]tag.Tag, *monitoredrespb.MonitoredResource) {
-	if get := e.o.GetMonitoredResource; get != nil {
-		newTags, mr := get(v, tags)
-		return newTags, convertMonitoredResourceToPB(mr)
-	}
 	resource := e.o.Resource
 	if resource == nil {
 		resource = &monitoredrespb.MonitoredResource{

stats_test.go

@@ -1080,81 +1080,6 @@ func TestExporter_makeReq_withCustomMonitoredResource(t *testing.T) {
 				},
 			},
 		},
-		{
-			name: "GetMonitoredResource and labels",
-			opts: func() Options {
-				var labels Labels
-				labels.Set("pid", "1234", "Process identifier")
-				return Options{
-					GetMonitoredResource: func(v *view.View, t []tag.Tag) ([]tag.Tag, monitoredresource.Interface) {
-						return t, gceInst
-					},
-					DefaultMonitoringLabels: &labels,
-				}
-			}(),
-			vd: newTestViewData(v, start, end, count1, count2),
-			want: []*monitoringpb.CreateTimeSeriesRequest{
-				{
-					Name: monitoring.MetricProjectPath("proj-id"),
-					TimeSeries: []*monitoringpb.TimeSeries{
-						{
-							Metric: &metricpb.Metric{
-								Type: "custom.googleapis.com/opencensus/testview",
-								Labels: map[string]string{
-									"test_key": "test-value-1",
-									"pid":      "1234",
-								},
-							},
-							Resource: resource,
-							Points: []*monitoringpb.Point{
-								{
-									Interval: &monitoringpb.TimeInterval{
-										StartTime: &timestamp.Timestamp{
-											Seconds: start.Unix(),
-											Nanos:   int32(start.Nanosecond()),
-										},
-										EndTime: &timestamp.Timestamp{
-											Seconds: end.Unix(),
-											Nanos:   int32(end.Nanosecond()),
-										},
-									},
-									Value: &monitoringpb.TypedValue{Value: &monitoringpb.TypedValue_Int64Value{
-										Int64Value: 10,
-									}},
-								},
-							},
-						},
-						{
-							Metric: &metricpb.Metric{
-								Type: "custom.googleapis.com/opencensus/testview",
-								Labels: map[string]string{
-									"test_key": "test-value-2",
-									"pid":      "1234",
-								},
-							},
-							Resource: resource,
-							Points: []*monitoringpb.Point{
-								{
-									Interval: &monitoringpb.TimeInterval{
-										StartTime: &timestamp.Timestamp{
-											Seconds: start.Unix(),
-											Nanos:   int32(start.Nanosecond()),
-										},
-										EndTime: &timestamp.Timestamp{
-											Seconds: end.Unix(),
-											Nanos:   int32(end.Nanosecond()),
-										},
-									},
-									Value: &monitoringpb.TypedValue{Value: &monitoringpb.TypedValue_Int64Value{
-										Int64Value: 16,
-									}},
-								},
-							},
-						},
-					},
-				},
-			},
-		},
 		{
 			name: "custom default monitoring labels",
 			opts: func() Options {