MGM,FST: Users can specify a checksum type alongside with the checksum of the file to be transferred

This can be done by appending eos.checksumtype=<ckstype> to the opaque query of
the destination file (eos.checksum=<cksum> must be provided as well).
If the ckstype passed in the opaque does not match any supported
checksum algorithm, the transfer will fail with EINVAL

Fixes EOS-6447

Author: ccaffy

fst/XrdFstOfsFile.cc

@@ -2720,6 +2720,7 @@ XrdFstOfsFile::ProcessMixedOpaque()
   using eos::common::FileId;
   // Handle checksum request
   std::string opaqueCheckSum;
+  std::string opaqueCheckSumTypeReq;
   char* val = nullptr;
 
   if (mOpenOpaque == nullptr || mCapOpaque == nullptr) {
@@ -2734,8 +2735,18 @@ XrdFstOfsFile::ProcessMixedOpaque()
   // Call the checksum factory function with the selected layout
   if (opaqueCheckSum != "ignore") {
     mCheckSum = eos::fst::ChecksumPlugins::GetChecksumObject(mLid);
-    eos_debug("msg=\"checksum requested\" xs_ptr=%p lid=%u mgm.checksum=\"%s\"",
-              mCheckSum.get(), mLid, opaqueCheckSum.c_str());
+    if(!opaqueCheckSum.empty() && (val = mOpenOpaque->Get("mgm.checksumtypereq"))) {
+      // the mgm.checksum has been set and the user requested a checksum type
+      opaqueCheckSumTypeReq = val;
+      mCheckSum = eos::fst::ChecksumPlugins::GetXsObj(opaqueCheckSumTypeReq);
+      if(!mCheckSum) {
+        // The checksum type was requested but does not exist, return an error to the client instead of copying the file without the checksum check
+        return gOFS.Emsg(epname, error, EINVAL,
+                         "open - the checksum type requested does not exist", opaqueCheckSumTypeReq.c_str());
+      }
+    }
+    eos_debug("msg=\"checksum requested\" xs_ptr=%p lid=%u mgm.checksum=\"%s\" mgm.checksumtypereq=\"%s\"",
+              mCheckSum.get(), mLid, opaqueCheckSum.c_str(), opaqueCheckSumTypeReq.c_str());
   }
 
   // Handle file system id and local prefix - If we open a replica we have to

mgm/XrdMgmOfsFile.cc

@@ -3361,6 +3361,12 @@ XrdMgmOfsFile::open(eos::common::VirtualIdentity* invid,
     if (openOpaque->Get("eos.checksum") || openOpaque->Get("eos.cloneid")) {
       redirectionhost += "&mgm.checksum=";
       redirectionhost += openOpaque->Get("eos.checksum");
+
+      if(openOpaque->Get("eos.checksumtype")) {
+        // User sets the checksum type corresponding to the eos.checksum specified
+        redirectionhost += "&mgm.checksumtypereq=";
+        redirectionhost += openOpaque->Get("eos.checksumtype");
+      }
     }
 
     if (openOpaque->Get("eos.mtime")) {

test/eos-instance-test

@@ -778,6 +778,10 @@ runtest "### downrnd   " unix 0 "" downloadrandom  /eos/$EOS_TEST_INSTANCE/test/
 runtest "### Rem       " unix 2 "" eos rm    "/eos/$EOS_TEST_INSTANCE/test/instancetest/holes"
 # --------------------------
 runtest "### Attr      " unix 0 "" eos attr set sys.forced.checksum=adler /eos/$EOS_TEST_INSTANCE/test/instancetest/
+runtest "### UploadCks " unix 0 "" upload    "$TESTSYSFILE1K" "/eos/$EOS_TEST_INSTANCE/test/instancetest/faulty-checksum1k" "-ODeos.checksum="
+runtest "### UploadCks " unix 0 "" upload    "$TESTSYSFILE1K" "/eos/$EOS_TEST_INSTANCE/test/instancetest/faulty-checksum1k" "-ODeos.checksum=$CKS1K\&eos.checksumtype=adler"
+runtest "### UploadCks " unix 1 "" upload    "$TESTSYSFILE1K" "/eos/$EOS_TEST_INSTANCE/test/instancetest/faulty-checksum1k" "-ODeos.checksum=bliblablo\&eos.checksumtype=adler"
+runtest "### UploadCks " unix 1 "" upload    "$TESTSYSFILE1K" "/eos/$EOS_TEST_INSTANCE/test/instancetest/faulty-checksum1k" "-ODeos.checksum=$CKS1K\&eos.checksumtype=does_not_exist"
 runtest "### UploadCks " unix 0 "" upload    "$TESTSYSFILE1K" "/eos/$EOS_TEST_INSTANCE/test/instancetest/faulty-checksum1k" "-ODeos.checksum=$CKS1K"
 runtest "### FileInfo  " unix 0 "" eos fileinfo "/eos/$EOS_TEST_INSTANCE/test/instancetest/faulty-checksum1k -m | grep nrep=1"
 runtest "### UploadCks " unix 0 "" upload    "$TESTSYSFILE0K" "/eos/$EOS_TEST_INSTANCE/test/instancetest/good-checksum0k" "-ODeos.checksum=00000001"