Improve go-fips detection for all variants and subpackages

- Detect any go-fips variant (go-fips, go-fips-md5, etc.) using startswith()
- Check each package/subpackage independently for compliance
- Require matching tests for each go-fips usage (not just any test)
- Provide detailed error messages specifying which component lacks tests
- Handle subpackage test sections properly

Fixes comprehensive validation of go-fips test requirements.

Author: AmberArcadia

pre_commit_hooks/check_for_go_fips_test.py

@@ -10,41 +10,71 @@
 yaml = ruamel.yaml.YAML(typ="safe")
 
 
-def uses_go_fips(melange_cfg: dict[str, Any]) -> bool:
-    """Check if package uses go-fips."""
-    # Check environment packages
+def check_go_fips_compliance(melange_cfg: dict[str, Any]) -> tuple[bool, list[str]]:
+    """
+    Check if all go-fips usages have corresponding tests.
+    Returns (is_compliant, list_of_missing_tests).
+    """
+    issues = []
+    
+    # Check if main package uses go-fips
+    main_uses_fips = False
+    main_has_test = False
+    
+    # Check environment packages for any go-fips variant
     env_packages = melange_cfg.get("environment", {}).get("contents", {}).get("packages", [])
-    if "go-fips" in env_packages:
-        return True
+    for pkg in env_packages:
+        if pkg.startswith("go-fips"):
+            main_uses_fips = True
+            break
 
-    # Check pipeline steps for go/build with go-package: go-fips
+    # Check main pipeline steps for go/build with go-package: go-fips*
     pipelines = melange_cfg.get("pipeline", [])
     for step in pipelines:
         if step.get("uses") == "go/build":
-            if step.get("with", {}).get("go-package") == "go-fips":
-                return True
-    
-    # Check subpackage pipelines
-    for subpkg in melange_cfg.get("subpackages", []):
-        subpkg_pipelines = subpkg.get("pipeline", [])
-        for step in subpkg_pipelines:
-            if step.get("uses") == "go/build":
-                if step.get("with", {}).get("go-package") == "go-fips":
-                    return True
+            go_package = step.get("with", {}).get("go-package", "")
+            if go_package.startswith("go-fips"):
+                main_uses_fips = True
+                break
 
-    return False
-
-
-def has_go_fips_test(melange_cfg: dict[str, Any]) -> bool:
-    """Check if package has go-fips test."""
+    # Check main test section
     test_section = melange_cfg.get("test", {})
     test_pipelines = test_section.get("pipeline", [])
-    
     for step in test_pipelines:
         if step.get("uses") == "test/go-fips-check":
-            return True
+            main_has_test = True
+            break
+    
+    if main_uses_fips and not main_has_test:
+        issues.append("main package uses go-fips but lacks test/go-fips-check")
 
-    return False
+    # Check each subpackage
+    for i, subpkg in enumerate(melange_cfg.get("subpackages", [])):
+        subpkg_uses_fips = False
+        subpkg_has_test = False
+        subpkg_name = subpkg.get("name", f"subpackage-{i}")
+        
+        # Check subpackage pipelines for go-fips usage
+        subpkg_pipelines = subpkg.get("pipeline", [])
+        for step in subpkg_pipelines:
+            if step.get("uses") == "go/build":
+                go_package = step.get("with", {}).get("go-package", "")
+                if go_package.startswith("go-fips"):
+                    subpkg_uses_fips = True
+                    break
+        
+        # Check subpackage test sections
+        subpkg_test_section = subpkg.get("test", {})
+        subpkg_test_pipelines = subpkg_test_section.get("pipeline", [])
+        for step in subpkg_test_pipelines:
+            if step.get("uses") == "test/go-fips-check":
+                subpkg_has_test = True
+                break
+        
+        if subpkg_uses_fips and not subpkg_has_test:
+            issues.append(f"subpackage '{subpkg_name}' uses go-fips but lacks test/go-fips-check")
+    
+    return len(issues) == 0, issues
 
 
 def main(argv: Sequence[str] | None = None) -> int:
@@ -68,13 +98,11 @@ def main(argv: Sequence[str] | None = None) -> int:
         if not melange_cfg:
             continue
 
-        if uses_go_fips(melange_cfg):
-            if not has_go_fips_test(melange_cfg):
-                print(
-                    f"{filename}: Package uses go-fips but does not have "
-                    "a corresponding go-fips test (add '- uses: test/go-fips-check' to test pipeline)"
-                )
-                retval = 1
+        is_compliant, issues = check_go_fips_compliance(melange_cfg)
+        if not is_compliant:
+            for issue in issues:
+                print(f"{filename}: {issue}")
+            retval = 1
 
     return retval