Changed to spotbugs

Author: ricellis

Jenkinsfile

@@ -57,15 +57,15 @@ stage('QA') {
 
     // Standard builds do Findbugs and test against Cloudant
     def axes = [
-            Findbugs:
+            Spotbugs:
                     {
                         node {
                             unstash name: 'built'
-                            // findBugs
+                            // Spotbugs
                             try {
-                                sh './gradlew -Dfindbugs.xml.report=true findbugsMain'
+                                sh './gradlew -Dspotbugs.xml.report=true spotbugsMain'
                             } finally {
-                                step([$class: 'FindBugsPublisher', pattern: '**/build/reports/findbugs/*.xml'])
+                                recordIssues enabledForFailure: true, tool: spotBugs(pattern: '**/build/reports/spotbugs/*.xml')
                             }
                         }
                     },

build.gradle

@@ -12,6 +12,10 @@
  * and limitations under the License.
  */
 
+plugins {
+    id "com.github.spotbugs" version "2.0.0" apply false
+}
+
 subprojects {
     apply plugin: 'java'
     apply plugin: 'maven'
@@ -175,24 +179,24 @@ subprojects {
     }
 
     // Findbugs
-    apply plugin: 'findbugs'
-    findbugs {
-        toolVersion = "3.0.1"
+    apply plugin: 'com.github.spotbugs'
+    spotbugs {
+        toolVersion = "3.1.12"
         // Report only high severity bugs for now
         reportLevel = "low"
         // The code base is pretty small so use max effort
         effort = "max"
         // We don't want to run findbugs on the test code yet
         sourceSets = [sourceSets.main]
         // Exclude a couple of known bugs until we get the chance to fix them
-        if (file("findbugs_excludes.xml").exists()) {
-            excludeFilter = file("findbugs_excludes.xml")
+        if (file("spotbugs_excludes.xml").exists()) {
+            excludeFilter = file("spotbugs_excludes.xml")
         }
     }
 
-    tasks.withType(FindBugs) {
+    tasks.withType(com.github.spotbugs.SpotBugsTask) {
         // Currently only one report type can be used toggle which with a property
-        boolean generateXML = Boolean.getBoolean("findbugs.xml.report")
+        boolean generateXML = Boolean.getBoolean("spotbugs.xml.report")
         reports {
             xml.enabled = generateXML
             html.enabled = !generateXML