feat: add focus check for pressKey() editing combos (Ctrl+A/C/X/V/Z/Y)

NonFocusedType now accepts message from caller. checkFocusBeforePressKey()
warns/throws only for editing key combos (Ctrl/Meta + A/C/X/V/Z/Y), not
for navigation keys like Escape or Tab.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: DavertMik

lib/helper/Playwright.js

@@ -7,7 +7,7 @@ import promiseRetry from 'promise-retry'
 import Locator from '../locator.js'
 import recorder from '../recorder.js'
 import store from '../store.js'
-import { checkFocusBeforeType } from './extras/focusCheck.js'
+import { checkFocusBeforeType, checkFocusBeforePressKey } from './extras/focusCheck.js'
 import { includes as stringIncludes } from '../assert/include.js'
 import { urlEquals, equals } from '../assert/equal.js'
 import { empty } from '../assert/empty.js'
@@ -2246,6 +2246,7 @@ class Playwright extends Helper {
     } else {
       key = getNormalizedKey.call(this, key)
     }
+    await checkFocusBeforePressKey(this, modifiers, key)
     for (const modifier of modifiers) {
       await this.page.keyboard.down(modifier)
     }

lib/helper/Puppeteer.js

@@ -8,7 +8,7 @@ import promiseRetry from 'promise-retry'
 import Locator from '../locator.js'
 import recorder from '../recorder.js'
 import store from '../store.js'
-import { checkFocusBeforeType } from './extras/focusCheck.js'
+import { checkFocusBeforeType, checkFocusBeforePressKey } from './extras/focusCheck.js'
 import { includes as stringIncludes } from '../assert/include.js'
 import { urlEquals, equals } from '../assert/equal.js'
 import { empty } from '../assert/empty.js'
@@ -1562,6 +1562,7 @@ class Puppeteer extends Helper {
     } else {
       key = getNormalizedKey.call(this, key)
     }
+    await checkFocusBeforePressKey(this, modifiers, key)
     for (const modifier of modifiers) {
       await this.page.keyboard.down(modifier)
     }

lib/helper/WebDriver.js

@@ -10,7 +10,7 @@ import promiseRetry from 'promise-retry'
 import { includes as stringIncludes } from '../assert/include.js'
 import { urlEquals, equals } from '../assert/equal.js'
 import store from '../store.js'
-import { checkFocusBeforeType } from './extras/focusCheck.js'
+import { checkFocusBeforeType, checkFocusBeforePressKey } from './extras/focusCheck.js'
 import output from '../output.js'
 const { debug } = output
 import { empty } from '../assert/empty.js'
@@ -2252,6 +2252,7 @@ class WebDriver extends Helper {
     } else {
       key = getNormalizedKey.call(this, key)
     }
+    await checkFocusBeforePressKey(this, modifiers, key)
     for (const modifier of modifiers) {
       await this.pressKeyDown(modifier)
     }

lib/helper/errors/NonFocusedType.js

@@ -1,9 +1,6 @@
 class NonFocusedType extends Error {
-  constructor() {
-    super(
-      'No element is in focus. Use I.click() or I.focus() to activate an element before calling I.type(). '
-      + 'This error is thrown because strict mode is enabled.',
-    )
+  constructor(message) {
+    super(message)
     this.name = 'NonFocusedType'
   }
 }

lib/helper/extras/focusCheck.js

@@ -1,20 +1,34 @@
 import store from '../../store.js'
 import NonFocusedType from '../errors/NonFocusedType.js'
 
-export async function checkFocusBeforeType(helper) {
-  const isStrict = helper.options.strict
-  if (!isStrict && !store.debugMode) return
+const EDITING_KEYS = new Set(['a', 'c', 'x', 'v', 'z', 'y'])
 
-  const noFocus = await helper.executeScript(() => {
+async function isNoElementFocused(helper) {
+  return helper.executeScript(() => {
     const ae = document.activeElement
     return !ae || ae === document.documentElement || (ae === document.body && !ae.isContentEditable)
   })
+}
+
+export async function checkFocusBeforeType(helper) {
+  if (!helper.options.strict && !store.debugMode) return
+  if (!await isNoElementFocused(helper)) return
+
+  const message = 'No element is in focus. Use I.click() or I.focus() to activate an element before typing.'
+  if (helper.options.strict) throw new NonFocusedType(message)
+  helper.debugSection('Warning', message)
+}
+
+export async function checkFocusBeforePressKey(helper, modifiers, key) {
+  if (!helper.options.strict && !store.debugMode) return
 
-  if (!noFocus) return
+  const hasCtrlOrMeta = modifiers.some(m => m === 'Control' || m === 'Meta'
+    || m === 'ControlLeft' || m === 'ControlRight' || m === 'MetaLeft' || m === 'MetaRight')
+  if (!hasCtrlOrMeta || !EDITING_KEYS.has(key.toLowerCase())) return
 
-  if (isStrict) {
-    throw new NonFocusedType()
-  }
+  if (!await isNoElementFocused(helper)) return
 
-  helper.debugSection('Warning', 'No element is in focus. Use I.click() or I.focus() to activate an element before typing.')
+  const message = `No element is in focus. Key combination with "${key}" may not work as expected. Use I.click() or I.focus() first.`
+  if (helper.options.strict) throw new NonFocusedType(message)
+  helper.debugSection('Warning', message)
 }

test/helper/webapi.js

@@ -2344,7 +2344,6 @@ export function tests() {
       expect(err).to.exist
       expect(err.constructor.name).to.equal('NonFocusedType')
       expect(err.message).to.include('No element is in focus')
-      expect(err.message).to.include('strict mode')
     })
 
     it('should not throw NonFocusedType when element is focused', async () => {
@@ -2354,6 +2353,33 @@ export function tests() {
       await I.type('test')
       await I.seeInField('Name', 'test')
     })
+
+    it('should throw NonFocusedType for Ctrl+A without focus', async () => {
+      await I.amOnPage('/form/field')
+      I.options.strict = true
+      let err
+      try {
+        await I.pressKey(['Control', 'A'])
+      } catch (e) {
+        err = e
+      }
+      expect(err).to.exist
+      expect(err.constructor.name).to.equal('NonFocusedType')
+      expect(err.message).to.include('No element is in focus')
+    })
+
+    it('should not throw for Escape without focus', async () => {
+      await I.amOnPage('/form/field')
+      I.options.strict = true
+      await I.pressKey('Escape')
+    })
+
+    it('should not throw for Ctrl+A when element is focused', async () => {
+      await I.amOnPage('/form/field')
+      I.options.strict = true
+      await I.click('Name')
+      await I.pressKey(['Control', 'A'])
+    })
   })
 
   describe('#elementIndex step option', () => {